Null checks for various extension config things (#944)

* null checks for various extension config things

* changelog

Author: zth

CHANGELOG.md

@@ -12,6 +12,10 @@
 
 ## master
 
+#### :bug: Bug Fix
+
+- Fix null checks for editor config, so things don't blow up. https://github.com/rescript-lang/rescript-vscode/pull/944
+
 ## 1.44.0
 
 #### :rocket: New Feature

server/src/config.ts

@@ -5,17 +5,17 @@ export type send = (msg: Message) => void;
 export interface extensionConfiguration {
   allowBuiltInFormatter: boolean;
   askToStartBuild: boolean;
-  inlayHints: {
+  inlayHints?: {
     enable: boolean;
     maxLength: number | null;
   };
   codeLens: boolean;
   binaryPath: string | null;
   platformPath: string | null;
-  signatureHelp: {
+  signatureHelp?: {
     enabled: boolean;
   };
-  incrementalTypechecking: {
+  incrementalTypechecking?: {
     enabled: boolean;
     acrossFiles: boolean;
     debugLogging: boolean;
@@ -40,7 +40,7 @@ let config: { extensionConfiguration: extensionConfiguration } = {
     },
     incrementalTypechecking: {
       enabled: false,
-      acrossFiles: true,
+      acrossFiles: false,
       debugLogging: true,
     },
   },

server/src/incrementalCompilation.ts

@@ -11,7 +11,9 @@ import * as c from "./constants";
 import * as chokidar from "chokidar";
 
 function debug() {
-  return config.extensionConfiguration.incrementalTypechecking.debugLogging;
+  return (
+    config.extensionConfiguration.incrementalTypechecking?.debugLogging ?? false
+  );
 }
 
 const INCREMENTAL_FOLDER_NAME = "___incremental";
@@ -420,7 +422,7 @@ async function figureOutBscArgs(entry: IncrementallyCompiledFileInfo) {
 
   let callArgs: Array<string> = [];
 
-  if (config.extensionConfiguration.incrementalTypechecking.acrossFiles) {
+  if (config.extensionConfiguration.incrementalTypechecking?.acrossFiles) {
     callArgs.push(
       "-I",
       path.resolve(entry.project.rootPath, INCREMENTAL_FILE_FOLDER_LOCATION)

server/src/server.ts

@@ -191,7 +191,7 @@ let deleteProjectDiagnostics = (projectRootPath: string) => {
     });
 
     projectsFiles.delete(projectRootPath);
-    if (config.extensionConfiguration.incrementalTypechecking.enabled) {
+    if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
       ic.removeIncrementalFileFolder(projectRootPath);
     }
   }
@@ -239,7 +239,7 @@ let openedFile = (fileUri: string, fileContent: string) => {
   if (projectRootPath != null) {
     let projectRootState = projectsFiles.get(projectRootPath);
     if (projectRootState == null) {
-      if (config.extensionConfiguration.incrementalTypechecking.enabled) {
+      if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
         ic.recreateIncrementalFileFolder(projectRootPath);
       }
       projectRootState = {
@@ -319,7 +319,7 @@ let openedFile = (fileUri: string, fileContent: string) => {
 let closedFile = (fileUri: string) => {
   let filePath = fileURLToPath(fileUri);
 
-  if (config.extensionConfiguration.incrementalTypechecking.enabled) {
+  if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
     ic.handleClosedFile(filePath);
   }
 
@@ -349,7 +349,7 @@ let updateOpenedFile = (fileUri: string, fileContent: string) => {
   let filePath = fileURLToPath(fileUri);
   assert(stupidFileContentCache.has(filePath));
   stupidFileContentCache.set(filePath, fileContent);
-  if (config.extensionConfiguration.incrementalTypechecking.enabled) {
+  if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
     ic.handleUpdateOpenedFile(filePath, fileContent, send, () => {
       if (config.extensionConfiguration.codeLens) {
         sendCodeLensRefresh();
@@ -418,7 +418,7 @@ function inlayHint(msg: p.RequestMessage) {
       filePath,
       params.range.start.line,
       params.range.end.line,
-      config.extensionConfiguration.inlayHints.maxLength,
+      config.extensionConfiguration.inlayHints?.maxLength,
     ],
     msg
   );
@@ -794,7 +794,7 @@ function format(msg: p.RequestMessage): Array<p.Message> {
 }
 
 let updateDiagnosticSyntax = (fileUri: string, fileContent: string) => {
-  if (config.extensionConfiguration.incrementalTypechecking.enabled) {
+  if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
     // The incremental typechecking already sends syntax diagnostics.
     return;
   }