-
Notifications
You must be signed in to change notification settings - Fork 57
/
Copy pathcodeActions.ts
766 lines (664 loc) · 17.7 KB
/
codeActions.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
// This file holds code actions derived from diagnostics. There are more code
// actions available in the extension, but they are derived via the analysis
// OCaml binary.
import * as p from "vscode-languageserver-protocol";
import * as utils from "./utils";
import { fileURLToPath } from "url";
export type fileCodeActions = { range: p.Range; codeAction: p.CodeAction };
export type filesCodeActions = {
[key: string]: fileCodeActions[];
};
interface findCodeActionsConfig {
diagnostic: p.Diagnostic;
diagnosticMessage: string[];
file: string;
range: p.Range;
addFoundActionsHere: filesCodeActions;
}
let wrapRangeInText = (
range: p.Range,
wrapStart: string,
wrapEnd: string
): p.TextEdit[] => {
// We need to adjust the start of where we replace if this is a single
// character on a single line.
let offset =
range.start.line === range.end.line &&
range.start.character === range.end.character
? 1
: 0;
let startRange = {
start: {
line: range.start.line,
character: range.start.character - offset,
},
end: {
line: range.start.line,
character: range.start.character - offset,
},
};
let endRange = {
start: {
line: range.end.line,
character: range.end.character,
},
end: {
line: range.end.line,
character: range.end.character,
},
};
return [
{
range: startRange,
newText: wrapStart,
},
{
range: endRange,
newText: wrapEnd,
},
];
};
let insertBeforeEndingChar = (
range: p.Range,
newText: string
): p.TextEdit[] => {
let beforeEndingChar = {
line: range.end.line,
character: range.end.character - 1,
};
return [
{
range: {
start: beforeEndingChar,
end: beforeEndingChar,
},
newText,
},
];
};
let replaceText = (range: p.Range, newText: string): p.TextEdit[] => {
return [
{
range,
newText,
},
];
};
let removeTrailingComma = (text: string): string => {
let str = text.trim();
if (str.endsWith(",")) {
return str.slice(0, str.length - 1);
}
return str;
};
let extractTypename = (lines: string[]): string => {
let arrFiltered: string[] = [];
for (let i = 0; i <= lines.length - 1; i += 1) {
let line = lines[i];
if (line.includes("(defined as")) {
let [typeStr, _] = line.split("(defined as");
arrFiltered.push(removeTrailingComma(typeStr));
break;
} else {
arrFiltered.push(removeTrailingComma(line));
}
}
return arrFiltered.join("").trim();
};
let takeUntil = (array: string[], startsWith: string): string[] => {
let res: string[] = [];
let arr = array.slice();
let matched = false;
arr.forEach((line) => {
if (matched) {
return;
}
if (line.startsWith(startsWith)) {
matched = true;
} else {
res.push(line);
}
});
return res;
};
export let findCodeActionsInDiagnosticsMessage = ({
diagnostic,
diagnosticMessage,
file,
range,
addFoundActionsHere: codeActions,
}: findCodeActionsConfig) => {
diagnosticMessage.forEach((line, index, array) => {
// Because of how actions work, there can only be one per diagnostic. So,
// halt whenever a code action has been found.
let codeActionEtractors = [
simpleTypeMismatches,
didYouMeanAction,
addUndefinedRecordFieldsV10,
addUndefinedRecordFieldsV11,
simpleConversion,
applyUncurried,
simpleAddMissingCases,
wrapInSome,
];
for (let extractCodeAction of codeActionEtractors) {
let didFindAction = false;
try {
didFindAction = extractCodeAction({
array,
codeActions,
diagnostic,
file,
index,
line,
range,
});
} catch (e) {
console.error(e);
}
if (didFindAction) {
break;
}
}
});
};
interface codeActionExtractorConfig {
line: string;
index: number;
array: string[];
file: string;
range: p.Range;
diagnostic: p.Diagnostic;
codeActions: filesCodeActions;
}
type codeActionExtractor = (config: codeActionExtractorConfig) => boolean;
// This action extracts hints the compiler emits for misspelled identifiers, and
// offers to replace the misspelled name with the correct name suggested by the
// compiler.
let didYouMeanAction: codeActionExtractor = ({
codeActions,
diagnostic,
file,
line,
range,
}) => {
if (line.startsWith("Hint: Did you mean")) {
let regex = /Did you mean ([A-Za-z0-9_]*)?/;
let match = line.match(regex);
if (match === null) {
return false;
}
let [_, suggestion] = match;
if (suggestion != null) {
codeActions[file] = codeActions[file] || [];
let codeAction: p.CodeAction = {
title: `Replace with '${suggestion}'`,
edit: {
changes: {
[file]: [{ range, newText: suggestion }],
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
}
return false;
};
// This action offers to wrap patterns that aren't option in Some.
let wrapInSome: codeActionExtractor = ({
codeActions,
diagnostic,
file,
line,
range,
array,
index,
}) => {
if (line.startsWith("This pattern matches values of type")) {
let regex = /This pattern matches values of type (.*)$/;
let match = line.match(regex);
if (match === null) {
return false;
}
let [_, type] = match;
if (!type.startsWith("option<")) {
// Look for the expected type
let restOfMessage = array.slice(index + 1);
let lineIndexWithType = restOfMessage.findIndex((l) =>
l
.trim()
.startsWith("but a pattern was expected which matches values of type")
);
if (lineIndexWithType === -1) return false;
// The type is either on this line or the next
let [_, typ = ""] = restOfMessage[lineIndexWithType].split(
"but a pattern was expected which matches values of type"
);
if (typ.trim() === "") {
// Type is on the next line
typ = (restOfMessage[lineIndexWithType + 1] ?? "").trim();
}
if (typ.trim().startsWith("option<")) {
codeActions[file] = codeActions[file] || [];
let codeAction: p.CodeAction = {
title: `Wrap in option Some`,
edit: {
changes: {
[file]: wrapRangeInText(range, `Some(`, `)`),
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
}
}
return false;
};
let handleUndefinedRecordFieldsAction = ({
recordFieldNames,
codeActions,
file,
range,
diagnostic,
}: {
recordFieldNames: string[];
codeActions: filesCodeActions;
file: string;
range: p.Range;
diagnostic: p.Diagnostic;
}) => {
if (recordFieldNames != null) {
codeActions[file] = codeActions[file] || [];
// The formatter outputs trailing commas automatically if the record
// definition is on multiple lines, and no trailing comma if it's on a
// single line. We need to adapt to this so we don't accidentally
// insert an invalid comma.
let multilineRecordDefinitionBody = range.start.line !== range.end.line;
// Let's build up the text we're going to insert.
let newText = "";
if (multilineRecordDefinitionBody) {
// If it's a multiline body, we know it looks like this:
// ```
// let someRecord = {
// atLeastOneExistingField: string,
// }
// ```
// We can figure out the formatting from the range the code action
// gives us. We'll insert to the direct left of the ending brace.
// The end char is the closing brace, and it's always going to be 2
// characters back from the record fields.
let paddingCharacters = multilineRecordDefinitionBody
? range.end.character + 2
: 0;
let paddingContentRecordField = Array.from({
length: paddingCharacters,
}).join(" ");
let paddingContentEndBrace = Array.from({
length: range.end.character,
}).join(" ");
recordFieldNames.forEach((fieldName, index) => {
if (index === 0) {
// This adds spacing from the ending brace up to the equivalent
// of the last record field name, needed for the first inserted
// record field name.
newText += " ";
} else {
// The rest of the new record field names will start from a new
// line, so they need left padding all the way to the same level
// as the rest of the record fields.
newText += paddingContentRecordField;
}
newText += `${fieldName}: failwith("TODO"),\n`;
});
// Let's put the end brace back where it was (we still have it to the direct right of us).
newText += `${paddingContentEndBrace}`;
} else {
// A single line record definition body is a bit easier - we'll just add the new fields on the same line.
newText += ", ";
newText += recordFieldNames
.map((fieldName) => `${fieldName}: failwith("TODO")`)
.join(", ");
}
let codeAction: p.CodeAction = {
title: `Add missing record fields`,
edit: {
changes: {
[file]: insertBeforeEndingChar(range, newText),
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
return false;
};
// This action handles when the compiler errors on certain fields of a record
// being undefined. We then offers an action that inserts all of the record
// fields, with an `assert false` dummy value. `assert false` is so applying the
// code action actually compiles.
let addUndefinedRecordFieldsV10: codeActionExtractor = ({
array,
codeActions,
diagnostic,
file,
index,
line,
range,
}) => {
if (line.startsWith("Some record fields are undefined:")) {
let recordFieldNames = line
.trim()
.split("Some record fields are undefined: ")[1]
?.split(" ");
// This collects the rest of the fields if fields are printed on
// multiple lines.
array.slice(index + 1).forEach((line) => {
recordFieldNames.push(...line.trim().split(" "));
});
return handleUndefinedRecordFieldsAction({
recordFieldNames,
codeActions,
diagnostic,
file,
range,
});
}
return false;
};
let addUndefinedRecordFieldsV11: codeActionExtractor = ({
array,
codeActions,
diagnostic,
file,
index,
line,
range,
}) => {
if (line.startsWith("Some required record fields are missing:")) {
let theLine = line;
if (theLine.endsWith(".")) {
theLine = theLine.slice(0, theLine.length - 2);
}
let recordFieldNames = theLine
.trim()
.split("Some required record fields are missing: ")[1]
?.split(" ");
// This collects the rest of the fields if fields are printed on
// multiple lines.
let stop = false;
array.slice(index + 1).forEach((line) => {
if (stop) return;
// Remove trailing dot, split the rest of the field names
recordFieldNames.push(...line.trim().split(".")[0].split(" "));
if (line.includes(".")) {
stop = true;
}
});
return handleUndefinedRecordFieldsAction({
recordFieldNames,
codeActions,
diagnostic,
file,
range,
});
}
return false;
};
// This action detects suggestions of converting between mismatches in types
// that the compiler tells us about.
let simpleConversion: codeActionExtractor = ({
line,
codeActions,
file,
range,
diagnostic,
}) => {
if (line.startsWith("You can convert ")) {
let regex = /You can convert (\w*) to (\w*) with ([\w.]*).$/;
let match = line.match(regex);
if (match === null) {
return false;
}
let [_, from, to, fn] = match;
if (from != null && to != null && fn != null) {
codeActions[file] = codeActions[file] || [];
let codeAction: p.CodeAction = {
title: `Convert ${from} to ${to} with ${fn}`,
edit: {
changes: {
[file]: wrapRangeInText(range, `${fn}(`, `)`),
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
}
return false;
};
// This action will apply a curried function (essentially inserting a dot in the
// correct place).
let applyUncurried: codeActionExtractor = ({
line,
codeActions,
file,
range,
diagnostic,
}) => {
if (
line.startsWith(
"This is an uncurried ReScript function. It must be applied with a dot."
)
) {
const locOfOpenFnParens = {
line: range.end.line,
character: range.end.character + 1,
};
codeActions[file] = codeActions[file] || [];
let codeAction: p.CodeAction = {
title: `Apply uncurried function call with dot`,
edit: {
changes: {
[file]: [
{
range: {
start: locOfOpenFnParens,
end: locOfOpenFnParens,
},
/*
* Turns `fn(123)` into `fn(. 123)`.
*/
newText: `. `,
},
],
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
return false;
};
// This action detects missing cases for exhaustive pattern matches, and offers
// to insert dummy branches (using `failwith("TODO")`) for those branches.
let simpleAddMissingCases: codeActionExtractor = ({
line,
codeActions,
file,
range,
diagnostic,
array,
index,
}) => {
if (
line.startsWith("You forgot to handle a possible case here, for example:")
) {
// This collects the rest of the fields if fields are printed on
// multiple lines.
let allCasesAsOneLine = array
.slice(index + 1)
.join("")
.trim();
let filePath = fileURLToPath(file);
let newSwitchCode = utils.runAnalysisAfterSanityCheck(filePath, [
"codemod",
filePath,
range.start.line,
range.start.character,
"add-missing-cases",
allCasesAsOneLine,
]);
codeActions[file] = codeActions[file] || [];
let codeAction: p.CodeAction = {
title: `Insert missing cases`,
edit: {
changes: {
[file]: replaceText(range, newSwitchCode),
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
return false;
};
// This detects concrete variables or values put in a position which expects an
// optional of that same type, and offers to wrap the value/variable in
// `Some()`.
let simpleTypeMismatches: codeActionExtractor = ({
line,
codeActions,
file,
range,
diagnostic,
array,
index,
}) => {
// Examples:
//
// 46 │ let as_ = {
// 47 │ someProp: "123",
// 48 │ another: "123",
// 49 │ }
// 50 │
// This has type: string
// Somewhere wanted: option<string>
//
// ...but types etc can also be on multilines, so we need a good
// amount of cleanup.
let lookFor = "This has type:";
if (line.startsWith(lookFor)) {
let thisHasTypeArr = takeUntil(
[line.slice(lookFor.length), ...array.slice(index + 1)],
"Somewhere wanted:"
);
let somewhereWantedArr = array
.slice(index + thisHasTypeArr.length)
.map((line) => line.replace("Somewhere wanted:", ""));
let thisHasType = extractTypename(thisHasTypeArr);
let somewhereWanted = extractTypename(somewhereWantedArr);
// Switching over an option
if (thisHasType === `option<${somewhereWanted}>`) {
codeActions[file] = codeActions[file] || [];
// We can figure out default values for primitives etc.
let defaultValue = "assert false";
switch (somewhereWanted) {
case "string": {
defaultValue = `"-"`;
break;
}
case "bool": {
defaultValue = `false`;
break;
}
case "int": {
defaultValue = `-1`;
break;
}
case "float": {
defaultValue = `-1.`;
break;
}
}
let codeAction: p.CodeAction = {
title: `Unwrap optional value`,
edit: {
changes: {
[file]: wrapRangeInText(
range,
"switch ",
` { | None => ${defaultValue} | Some(v) => v }`
),
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
// Wrapping a non-optional in Some
if (`option<${thisHasType}>` === somewhereWanted) {
codeActions[file] = codeActions[file] || [];
let codeAction: p.CodeAction = {
title: `Wrap value in Some`,
edit: {
changes: {
[file]: wrapRangeInText(range, "Some(", ")"),
},
},
diagnostics: [diagnostic],
kind: p.CodeActionKind.QuickFix,
isPreferred: true,
};
codeActions[file].push({
range,
codeAction,
});
return true;
}
}
return false;
};