Fix for review

Author: Takuto Ikuta

src/clparser.cc

@@ -19,6 +19,7 @@
 #include <string.h>
 
 #include "metrics.h"
+#include "string_piece_util.h"
 
 #ifdef _WIN32
 #include "includes_normalize.h"
@@ -56,15 +57,15 @@ string CLParser::FilterShowIncludes(const string& line,
 
 // static
 bool CLParser::IsSystemInclude(string path) {
-  transform(path.begin(), path.end(), path.begin(), ::tolower);
+  transform(path.begin(), path.end(), path.begin(), ToLowerASCII);
   // TODO: this is a heuristic, perhaps there's a better way?
   return (path.find("program files") != string::npos ||
           path.find("microsoft visual studio") != string::npos);
 }
 
 // static
 bool CLParser::FilterInputFilename(string line) {
-  transform(line.begin(), line.end(), line.begin(), ::tolower);
+  transform(line.begin(), line.end(), line.begin(), ToLowerASCII);
   // TODO: other extensions, like .asm?
   return EndsWith(line, ".c") ||
       EndsWith(line, ".cc") ||

src/includes_normalize-win32.cc

@@ -38,29 +38,23 @@ bool SameDriveFast(StringPiece a, StringPiece b) {
     return false;
   }
 
-  if (!isalpha(a[0]) || !isalpha(b[0])) {
+  if (!islatinalpha(a[0]) || !islatinalpha(b[0])) {
     return false;
   }
 
-  if (tolower(a[0]) != tolower(b[0])) {
+  if (ToLowerASCII(a[0]) != ToLowerASCII(b[0])) {
     return false;
   }
 
   if (a[1] != ':' || b[1] != ':') {
     return false;
   }
 
-  if (!IsPathSeparator(a[2]) ||
-      !IsPathSeparator(b[2])) {
-    return false;
-  }
-
-  return true;
+  return IsPathSeparator(a[2]) && IsPathSeparator(b[2]);
 }
 
 // Return true if paths a and b are on the same Windows drive.
 bool SameDrive(StringPiece a, StringPiece b)  {
-  // Fast check.
   if (SameDriveFast(a, b)) {
     return true;
   }
@@ -76,9 +70,11 @@ bool SameDrive(StringPiece a, StringPiece b)  {
   return _stricmp(a_drive, b_drive) == 0;
 }
 
-bool IsAbsPath(StringPiece s) {
+// Check path |s| is FullPath style returned by GetFullPathName.
+// This ignores difference of path separator.
+bool IsFullPathName(StringPiece s) {
   if (s.size() < 3 ||
-      !isalpha(s[0]) ||
+      !islatinalpha(s[0]) ||
       s[1] != ':' ||
       !IsPathSeparator(s[2])) {
     return false;
@@ -110,11 +106,11 @@ bool IsAbsPath(StringPiece s) {
 
 IncludesNormalize::IncludesNormalize(const string& relative_to) {
   relative_to_ = AbsPath(relative_to);
-  splitted_relative_to_ = SplitStringPiece(relative_to_, '/');
+  split_relative_to_ = SplitStringPiece(relative_to_, '/');
 }
 
 string IncludesNormalize::AbsPath(StringPiece s) {
-  if (IsAbsPath(s)) {
+  if (IsFullPathName(s)) {
     string result = s.AsString();
     for (size_t i = 0; i < result.size(); ++i) {
       if (result[i] == '\\') {
@@ -132,7 +128,8 @@ string IncludesNormalize::AbsPath(StringPiece s) {
   return result;
 }
 
-string IncludesNormalize::Relativize(StringPiece path, const vector<StringPiece>& start_list) {
+string IncludesNormalize::Relativize(
+    StringPiece path, const vector<StringPiece>& start_list) {
   string abs_path = AbsPath(path);
   vector<StringPiece> path_list = SplitStringPiece(abs_path, '/');
   int i;
@@ -172,6 +169,6 @@ bool IncludesNormalize::Normalize(const string& input,
     *result = partially_fixed.AsString();
     return true;
   }
-  *result = Relativize(partially_fixed, splitted_relative_to_);
+  *result = Relativize(partially_fixed, split_relative_to_);
   return true;
 }

src/includes_normalize.h

@@ -30,10 +30,10 @@ struct IncludesNormalize {
                            const vector<StringPiece>& start_list);
 
   /// Normalize by fixing slashes style, fixing redundant .. and . and makes the
-  /// path relative to |relative_to_|.
+  /// path |input| relative to |this->relative_to_| and store to |result|.
   bool Normalize(const string& input, string* result, string* err) const;
 
  private:
   string relative_to_;
-  vector<StringPiece> splitted_relative_to_;
+  vector<StringPiece> split_relative_to_;
 };

src/util.cc

@@ -471,7 +471,7 @@ void Win32Fatal(const char* function) {
 }
 #endif
 
-static bool islatinalpha(int c) {
+bool islatinalpha(int c) {
   // isalpha() is locale-dependent.
   return (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z');
 }

src/util.h

@@ -70,6 +70,8 @@ const char* SpellcheckStringV(const string& text,
 /// Like SpellcheckStringV, but takes a NULL-terminated list.
 const char* SpellcheckString(const char* text, ...);
 
+bool islatinalpha(int c);
+
 /// Removes all Ansi escape codes (http://www.termsys.demon.co.uk/vtansi.htm).
 string StripAnsiEscapeCodes(const string& in);