Directly pass the string instead of char * to Truncate util function. It will prevent useless conversions.

HeisSpiter · HeisSpiter · commit 70e7007b327c · 2015-03-07T14:23:41.000+01:00
diff --git a/src/deps_log.cc b/src/deps_log.cc
@@ -275,7 +275,7 @@ bool DepsLog::Load(const string& path, State* state, string* err) {
     }
     fclose(f);
 
-    if (!Truncate(path.c_str(), offset, err))
+    if (!Truncate(path, offset, err))
       return false;
 
     // The truncate succeeded; we'll just report the load error as a

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ bool DepsLog::Load(const string& path, State* state, string* err) {`
`275`	`275`	`}`
`276`	`276`	`fclose(f);`
`277`	`277`
`278`		`- if (!Truncate(path.c_str(), offset, err))`
	`278`	`+ if (!Truncate(path, offset, err))`
`279`	`279`	`return false;`
`280`	`280`
`281`	`281`	`// The truncate succeeded; we'll just report the load error as a`