Skip to content

Commit 4356297

Browse files
author
Thomas Risberg
committed
Changed tests to use 'database' as the database name except for the repositories tests
1 parent d0da787 commit 4356297

File tree

7 files changed

+40
-22
lines changed

7 files changed

+40
-22
lines changed

spring-data-mongodb-cross-store/src/test/resources/META-INF/spring/applicationContext.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
<bean id="mongoDbFactory" class="org.springframework.data.document.mongodb.MongoDbFactoryBean">
2929
<constructor-arg name="mongo" ref="mongo"/>
30-
<constructor-arg name="databaseName" value="test"/>
30+
<constructor-arg name="databaseName" value="database"/>
3131
</bean>
3232

3333
<bean id="mongoTemplate" class="org.springframework.data.document.mongodb.MongoTemplate">

spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/GeoSpatialAppConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class GeoSpatialAppConfig extends AbstractMongoConfiguration {
2727

2828
@Override
2929
public String defaultDatabaseName() {
30-
return "geospatial";
30+
return "database";
3131
}
3232

3333
@Bean

spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/GeoSpatialTests.java

+19-13
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,18 @@
1919
import static org.hamcrest.Matchers.*;
2020
import static org.junit.Assert.assertThat;
2121

22+
import java.net.UnknownHostException;
2223
import java.util.Collection;
2324
import java.util.List;
2425

2526
import org.apache.commons.logging.Log;
2627
import org.apache.commons.logging.LogFactory;
28+
import org.junit.After;
2729
import org.junit.Before;
2830
import org.junit.Ignore;
2931
import org.junit.Test;
30-
import org.junit.runner.RunWith;
31-
import org.springframework.beans.factory.annotation.Autowired;
3232
import org.springframework.context.ApplicationContext;
3333
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
34-
import org.springframework.context.support.ClassPathXmlApplicationContext;
3534
import org.springframework.dao.DataAccessException;
3635
import org.springframework.data.document.mongodb.geo.Box;
3736
import org.springframework.data.document.mongodb.geo.Circle;
@@ -42,8 +41,6 @@
4241
import org.springframework.data.document.mongodb.query.Query;
4342
import org.springframework.expression.ExpressionParser;
4443
import org.springframework.expression.spel.standard.SpelExpressionParser;
45-
import org.springframework.test.context.ContextConfiguration;
46-
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
4744

4845
import com.mongodb.DB;
4946
import com.mongodb.DBCollection;
@@ -61,7 +58,7 @@
6158
public class GeoSpatialTests {
6259

6360
private static final Log LOGGER = LogFactory.getLog(GeoSpatialTests.class);
64-
private final String[] collectionsToDrop = new String[] { "newyork" };
61+
private final String[] collectionsToDrop = new String[] { "newyork", "Person" };
6562

6663
ApplicationContext applicationContext;
6764
MongoTemplate template;
@@ -71,12 +68,7 @@ public class GeoSpatialTests {
7168

7269
@Before
7370
public void setUp() throws Exception {
74-
Mongo mongo = new Mongo();
75-
serverInfo = new ServerInfo(mongo);
76-
DB db = mongo.getDB("geospatial");
77-
for (String coll : collectionsToDrop) {
78-
db.getCollection(coll).drop();
79-
}
71+
cleanDb();
8072
applicationContext = new AnnotationConfigApplicationContext(GeoSpatialAppConfig.class);
8173
template = applicationContext.getBean(MongoTemplate.class);
8274
template.setWriteConcern(WriteConcern.FSYNC_SAFE);
@@ -86,6 +78,20 @@ public void setUp() throws Exception {
8678
parser = new SpelExpressionParser();
8779
}
8880

81+
@After
82+
public void cleanUp() throws Exception {
83+
cleanDb();
84+
}
85+
86+
private void cleanDb() throws UnknownHostException {
87+
Mongo mongo = new Mongo();
88+
serverInfo = new ServerInfo(mongo);
89+
DB db = mongo.getDB("database");
90+
for (String coll : collectionsToDrop) {
91+
db.getCollection(coll).drop();
92+
}
93+
}
94+
8995
private void addVenues() {
9096

9197
template.insert(new Venue("Penn Station", -73.99408, 40.75057));
@@ -168,7 +174,7 @@ public void indexCreated() {
168174
LOGGER.debug(indexInfo);
169175
assertThat(indexInfo.size(), equalTo(2));
170176
assertThat(indexInfo.get(1).get("name").toString(), equalTo("location_2d"));
171-
assertThat(indexInfo.get(1).get("ns").toString(), equalTo("geospatial.newyork"));
177+
assertThat(indexInfo.get(1).get("ns").toString(), equalTo("database.newyork"));
172178
}
173179

174180
// TODO move to MongoAdmin

spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/MongoTemplateTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public void insertsSimpleEntityCorrectly() throws Exception {
113113
@Test
114114
public void updateFailure() throws Exception {
115115

116-
MongoTemplate mongoTemplate = new MongoTemplate(template.getDb().getMongo(), "test");
116+
MongoTemplate mongoTemplate = new MongoTemplate(template.getDbFactory());
117117
mongoTemplate.setWriteResultChecking(WriteResultChecking.EXCEPTION);
118118

119119
Person person = new Person("Oliver2");

spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/mapping/GeoIndexedAppConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
public class GeoIndexedAppConfig extends AbstractMongoConfiguration {
99

10-
public static String GEO_DB = "geodb";
10+
public static String GEO_DB = "database";
1111
public static String GEO_COLLECTION = "geolocation";
1212

1313
@Override

spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/mapping/GeoIndexedTests.java

+16-4
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,16 @@
1818

1919
import static org.junit.Assert.*;
2020

21+
import java.net.UnknownHostException;
2122
import java.util.List;
2223

2324
import com.mongodb.DB;
2425
import com.mongodb.DBCollection;
2526
import com.mongodb.DBObject;
2627
import com.mongodb.Mongo;
2728
import com.mongodb.MongoException;
29+
30+
import org.junit.After;
2831
import org.junit.Before;
2932
import org.junit.Test;
3033
import org.springframework.context.ApplicationContext;
@@ -44,22 +47,31 @@
4447
*/
4548
public class GeoIndexedTests {
4649

47-
private final String[] collectionsToDrop = new String[] { GeoIndexedAppConfig.GEO_COLLECTION };
50+
private final String[] collectionsToDrop = new String[] { GeoIndexedAppConfig.GEO_COLLECTION, "Person"};
4851

4952
ApplicationContext applicationContext;
5053
MongoTemplate template;
5154
MongoMappingContext mappingContext;
5255

5356
@Before
5457
public void setUp() throws Exception {
58+
cleanDb();
59+
applicationContext = new AnnotationConfigApplicationContext(GeoIndexedAppConfig.class);
60+
template = applicationContext.getBean(MongoTemplate.class);
61+
mappingContext = applicationContext.getBean(MongoMappingContext.class);
62+
}
63+
64+
@After
65+
public void cleanUp() throws Exception {
66+
cleanDb();
67+
}
68+
69+
private void cleanDb() throws UnknownHostException {
5570
Mongo mongo = new Mongo();
5671
DB db = mongo.getDB(GeoIndexedAppConfig.GEO_DB);
5772
for (String coll : collectionsToDrop) {
5873
db.getCollection(coll).drop();
5974
}
60-
applicationContext = new AnnotationConfigApplicationContext(GeoIndexedAppConfig.class);
61-
template = applicationContext.getBean(MongoTemplate.class);
62-
mappingContext = applicationContext.getBean(MongoMappingContext.class);
6375
}
6476

6577
@Test

spring-data-mongodb/src/test/resources/geospatial.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<bean id="mongoDbFactory" class="org.springframework.data.document.mongodb.MongoDbFactoryBean">
1111
<constructor-arg name="mongo" ref="mongo"/>
12-
<constructor-arg name="databaseName" value="geospatial"/>
12+
<constructor-arg name="databaseName" value="database"/>
1313
</bean>
1414

1515
<mongo:mapping-converter base-package="org.springframework.data.document.mongodb"/>

0 commit comments

Comments
 (0)