Skip to content

Fix swift compiler warnings in generated code #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Fix swift compiler warnings in generated code #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion compiler/src/main/java/com/readdle/codegen/SwiftFuncDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,21 @@ public void generateCode(SwiftWriter swiftWriter, String javaFullName, String sw
swiftWriter.emitStatement(String.format("let %s: %s%s", param.name, param.swiftType.swiftType, param.isOptional ? "?" : ""));
}

boolean shouldCatchPreamble = params.size() > 0 || !isStatic;

boolean shouldCatchPreamble = false;
if (isStatic) {
for (SwiftParamDescriptor param : params) {
// primitive types constructors not throw
if (param.isOptional || !param.isPrimitive()) {
shouldCatchPreamble = true;
break;
}
}
}
else {
shouldCatchPreamble = true;
}

if (shouldCatchPreamble) {
swiftWriter.emitStatement("do {");
}
Expand Down