Dev: fix local table overflow

Author: andriydruk

compiler/src/main/java/com/readdle/codegen/JavaSwiftProcessor.java

@@ -256,6 +256,13 @@ private void generateJavaSwift(Filer filer) throws IOException {
         swiftWriter.emitStatement("public func Java_com_readdle_codegen_anotation_JavaBridgeable_init(env: UnsafeMutablePointer<JNIEnv?>, clazz: jclass) {");
         swiftWriter.emitStatement("JavaCoderConfig.RegisterBasicJavaTypes()");
         swiftWriter.emitStatement("}");
+
+        // TODO: move to sample project
+        swiftWriter.emitStatement("@_silgen_name(\"Java_com_readdle_codegen_anotation_JavaSwift_dumpReferenceTables\")");
+        swiftWriter.emitStatement("public func Java_com_readdle_codegen_anotation_JavaBridgeable_dumpReferenceTables(env: UnsafeMutablePointer<JNIEnv?>, clazz: jclass) {");
+        swiftWriter.emitStatement("JNI.dumpReferenceTables()");
+        swiftWriter.emitStatement("}");
+
         swiftWriter.close();
     }
 

compiler/src/main/java/com/readdle/codegen/SwiftCallbackFuncDescriptor.java

@@ -1,7 +1,6 @@
 package com.readdle.codegen;
 
 import com.readdle.codegen.anotation.SwiftCallbackFunc;
-import com.readdle.codegen.anotation.SwiftFunc;
 
 import java.io.IOException;
 import java.util.Arrays;
@@ -111,16 +110,22 @@ void generateCode(SwiftWriter swiftWriter, String javaFullName, String swiftType
         }
 
         for (SwiftParamDescriptor param : params) {
-            swiftWriter.emitStatement(String.format("let java%s: JNIArgumentProtocol", param.name));
+            swiftWriter.emitStatement(String.format("var java%s: JNIArgumentProtocol = jnull()", param.name));
         }
 
+        swiftWriter.emitStatement("defer {");
+        for (SwiftParamDescriptor param : params) {
+            swiftWriter.emitStatement(String.format("if let localRef = java%1$s as? jobject {", param.name));
+            swiftWriter.emitStatement("JNI.DeleteLocalRef(localRef)");
+            swiftWriter.emitStatement("}");
+        }
+        swiftWriter.emitStatement("}");
+
         swiftWriter.emitStatement("do {");
         for (SwiftParamDescriptor param : params) {
             if (param.isOptional) {
                 swiftWriter.emitStatement(String.format("if let %1$s = %1$s {", param.name));
                 swiftWriter.emitStatement(String.format("java%1$s = try %1$s.javaObject()", param.name));
-                swiftWriter.emitStatement("} else {");
-                swiftWriter.emitStatement(String.format("java%s = jnull()", param.name));
                 swiftWriter.emitStatement("}");
             }
             else {
@@ -135,7 +140,10 @@ void generateCode(SwiftWriter swiftWriter, String javaFullName, String swiftType
             swiftWriter.emitStatement("assert(false, errorString)");
             swiftWriter.emitStatement("return");
         }
-        else {
+        else if (isReturnTypeOptional) {
+            swiftWriter.emitStatement("assert(false, errorString)");
+            swiftWriter.emitStatement("return nil");
+        } else {
             swiftWriter.emitStatement("fatalError(errorString)");
         }
         swiftWriter.emitStatement("}");

library/src/main/java/com/readdle/codegen/anotation/JavaSwift.java

@@ -6,4 +6,6 @@ private JavaSwift() {}
 
     public static native void init();
 
+    public static native void dumpReferenceTables();
+
 }

library/src/main/java/com/readdle/codegen/anotation/SwiftError.java

@@ -6,4 +6,8 @@ public SwiftError() {
 
     }
 
+    public SwiftError(String message) {
+        super(message);
+    }
+
 }

library/src/main/java/com/readdle/codegen/anotation/SwiftRuntimeError.java

@@ -6,4 +6,8 @@ public class SwiftRuntimeError extends RuntimeException {
     public SwiftRuntimeError() {
 
     }
+
+    public SwiftRuntimeError(String message) {
+        super(message);
+    }
 }