Prevent "interval" overflow in ExtUvLoop

Author: PabloKowalczyk

src/ExtUvLoop.php

@@ -127,7 +127,7 @@ public function addTimer($interval, $callback)
         $this->timers->attach($timer, $event);
         \uv_timer_start(
             $event,
-            (int) ($interval * 1000) + 1,
+            $this->convertFloatSecondsToMilliseconds($interval),
             0,
             $callback
         );
@@ -146,12 +146,13 @@ public function addPeriodicTimer($interval, $callback)
             \call_user_func($timer->getCallback(), $timer);
         };
 
+        $interval = $this->convertFloatSecondsToMilliseconds($interval);
         $event = \uv_timer_init($this->uv);
         $this->timers->attach($timer, $event);
         \uv_timer_start(
             $event,
-            (int) ($interval * 1000) + 1,
-            (int) ($interval * 1000) + 1,
+            $interval,
+            (int) $interval === 0 ? 1 : $interval,
             $callback
         );
 
@@ -313,4 +314,26 @@ private function createStreamListener()
 
         return $callback;
     }
+
+    /**
+     * @param float $interval
+     * @return int
+     */
+    private function convertFloatSecondsToMilliseconds($interval)
+    {
+        if ($interval < 0) {
+            return 0;
+        }
+
+        $maxValue = (int) (\PHP_INT_MAX / 1000);
+        $intInterval = (int) $interval;
+
+        if (($intInterval <= 0 && $interval > 1) || $intInterval >= $maxValue) {
+            throw new \InvalidArgumentException(
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$interval}' passed."
+            );
+        }
+
+        return (int) \floor($interval * 1000);
+    }
 }

tests/AbstractLoopTest.php

@@ -589,11 +589,20 @@ public function testSignalsKeepTheLoopRunningAndRemovingItStopsTheLoop()
         $this->assertRunFasterThan(1.6);
     }
 
+    public function testTimerIntervalBelowZeroRunsImmediately()
+    {
+        $this->loop->addTimer(-1, function () {});
+
+        $this->assertRunFasterThan(0.002);
+    }
+
     public function testTimerIntervalCanBeFarInFuture()
     {
+        // Maximum interval for ExtUvLoop implementation
+        $interval = ((int) (PHP_INT_MAX / 1000)) - 1;
         $loop = $this->loop;
         // start a timer very far in the future
-        $timer = $this->loop->addTimer(PHP_INT_MAX, function () { });
+        $timer = $this->loop->addTimer($interval, function () { });
 
         $this->loop->futureTick(function () use ($timer, $loop) {
             $loop->cancelTimer($timer);

tests/ExtUvLoopTest.php

@@ -14,4 +14,82 @@ public function createLoop()
 
         return new ExtUvLoop();
     }
+
+    /** @dataProvider intervalProvider */
+    public function testTimerInterval($interval, $expectedExceptionMessage)
+    {
+        $this->expectException('InvalidArgumentException');
+        $this->expectExceptionMessage($expectedExceptionMessage);
+
+        $this->loop
+            ->addTimer(
+                $interval,
+                function () {
+                    return 0;
+                }
+            );
+    }
+
+    public function intervalProvider()
+    {
+        $oversizeInterval = PHP_INT_MAX / 1000;
+        $maxValue = (int) (PHP_INT_MAX / 1000);
+        $oneMaxValue = $maxValue + 1;
+        $tenMaxValue = $maxValue + 10;
+        $tenMillionsMaxValue = $maxValue + 10000000;
+        $intMax = PHP_INT_MAX;
+        $oneIntMax = PHP_INT_MAX + 1;
+        $tenIntMax = PHP_INT_MAX + 10;
+        $oneHundredIntMax = PHP_INT_MAX + 100;
+        $oneThousandIntMax = PHP_INT_MAX + 1000;
+        $tenMillionsIntMax = PHP_INT_MAX + 10000000;
+        $tenThousandsTimesIntMax = PHP_INT_MAX * 1000;
+
+        return array(
+            array(
+                $oversizeInterval,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$oversizeInterval}' passed."
+            ),
+            array(
+                $oneMaxValue,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$oneMaxValue}' passed.",
+            ),
+            array(
+                $tenMaxValue,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$tenMaxValue}' passed.",
+            ),
+            array(
+                $tenMillionsMaxValue,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$tenMillionsMaxValue}' passed.",
+            ),
+            array(
+                $intMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$intMax}' passed.",
+            ),
+            array(
+                $oneIntMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$oneIntMax}' passed.",
+            ),
+            array(
+                $tenIntMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$tenIntMax}' passed.",
+            ),
+            array(
+                $oneHundredIntMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$oneHundredIntMax}' passed.",
+            ),
+            array(
+                $oneThousandIntMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$oneThousandIntMax}' passed.",
+            ),
+            array(
+                $tenMillionsIntMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$tenMillionsIntMax}' passed.",
+            ),
+            array(
+                $tenThousandsTimesIntMax,
+                "Interval overflow, value must be lower than '{$maxValue}', but '{$tenThousandsTimesIntMax}' passed.",
+            ),
+        );
+    }
 }