Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

example code is not map to corresponding lesson #318

Closed
yihaoye opened this issue May 16, 2017 · 1 comment
Closed

example code is not map to corresponding lesson #318

yihaoye opened this issue May 16, 2017 · 1 comment

Comments

@yihaoye
Copy link

yihaoye commented May 16, 2017

I use "git clone https://github.com/reactjs/react-router-tutorial" to download the tutorial, however some example codes seem not map to their lesson. Some example codes are map to last lesson.

For example:
react-router-tutorial/lessons/02-rendering-a-route have the same code with react-router-tutorial/lessons/01-setting-up
code in react-router-tutorial/lessons/03-navigating-with-link is for lesson 2
code in react-router-tutorial/lessons/04-nested-routes is for lesson 3
...

please have a check with all example code and modify them.

@zainulabidin302
Copy link

lesson 01 is introductory and there are no code changes in the first lesson. code changes start from lesson 02.

03 and 04 -> module/App.js files are not same and according to the flow of tutorial.

I don't see any redundancy.

@yihaoye yihaoye closed this as completed May 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants