Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md output path consistency #23

Closed
supirman opened this issue Feb 11, 2017 · 1 comment
Closed

README.md output path consistency #23

supirman opened this issue Feb 11, 2017 · 1 comment

Comments

@supirman
Copy link

Please make the output path to be consistent in example, so it easy to follow for beginer like me.
It has 3 different value :

  • public/react-toolbox in gif
  • assets/react-toolbox in README config example
  • src/toolbox in src/constants.js default setting
@javivelasco
Copy link
Member

The gif is outdated but its not worthy to re-record it just for the output path so I've added a note before it's shown in the README telling that the current output path is src/toolbox. In the README example it's ok because we are setting in the package: "output": "assets/react-toolbox". If you omit the setting it defaults to src/toolbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants