Skip to content

Fix #317: Remove defaultProps from LinkContainer #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix #317: Remove defaultProps from LinkContainer #318

merged 1 commit into from
Jun 19, 2024

Conversation

@reinard
Copy link
Contributor

@reinard reinard commented Jun 19, 2024 •
edited
Loading

This fixes the following console error that can be seen when using LinkContainer:

LinkContainer: Support for defaultProps will be removed from function components in a future major release.
Use JavaScript default parameters instead.

@reinard reinard mentioned this pull request Jun 19, 2024
Closed
@kyletsang kyletsang merged commit a74003a into react-bootstrap:master Jun 19, 2024
@kyletsang
Copy link
Member

kyletsang commented Jun 19, 2024

Thanks

@lcahlander lcahlander mentioned this pull request Jul 20, 2024
Open
@popas90 popas90 mentioned this pull request Jul 21, 2024
Merged
@geekswagg geekswagg mentioned this pull request Jul 24, 2024
Open
@bighia bighia mentioned this pull request Jul 27, 2024
Open
@megha-paliwal-121 megha-paliwal-121 mentioned this pull request Aug 18, 2024
Open
@EXTROMILE EXTROMILE mentioned this pull request Sep 26, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reinard @kyletsang