Fix for onClick handler not resolving "to" location correctly

Author: smashercosmo

src/LinkContainer.js

@@ -62,6 +62,10 @@ class LinkContainer extends React.Component {
       to, query, hash, state, children, onClick, target, action,
     } = this.props;
 
+    const { router } = this.context;
+
+    const toLocation = resolveToLocation(to, router);
+
     if (children.props.onClick) {
       children.props.onClick(event);
     }
@@ -81,8 +85,8 @@ class LinkContainer extends React.Component {
 
     event.preventDefault();
 
-    this.context.router[action](
-      createLocationDescriptor(to, query, hash, state)
+    router[action](
+      createLocationDescriptor(toLocation, query, hash, state)
     );
   };
 

test/LinkContainer.spec.js

@@ -127,6 +127,39 @@ describe('LinkContainer', () => {
           expect(target).to.exist;
         });
 
+        it('should transition to the correct route, with "to" prop as a function', () => {
+          const router = ReactTestUtils.renderIntoDocument(
+            <Router history={createMemoryHistory('/')}>
+              <Route
+                path="/"
+                component={() => (
+                  <LinkContainer
+                    to={() => ({
+                      pathname: '/target',
+                    })}
+                  >
+                    <Component>Target</Component>
+                  </LinkContainer>
+                )}
+              />
+              <Route
+                path="/target"
+                component={() => <div className="target" />}
+              />
+            </Router>
+          );
+
+          const anchor = ReactTestUtils.findRenderedDOMComponentWithTag(
+            router, 'A'
+          );
+          ReactTestUtils.Simulate.click(anchor, { button: 0 });
+
+          const target = ReactTestUtils.findRenderedDOMComponentWithClass(
+            router, 'target'
+          );
+          expect(target).to.exist;
+        });
+
         it('should call user defined click handlers', () => {
           const onClick = sinon.spy();
           const childOnClick = sinon.spy();