Fix styles

Author: railspulse

app/helpers/rails_pulse/application_helper.rb

@@ -16,9 +16,25 @@ def rails_pulse_icon(name, options = {})
       width = options[:width] || options["width"] || 24
       height = options[:height] || options["height"] || 24
       css_class = options[:class] || options["class"] || ""
+      custom_style = options[:style] || options["style"]
+
+      # Normalize numeric width/height values into px for layout stability
+      width_css = normalize_dimension(width)
+      height_css = normalize_dimension(height)
+
+      default_style = [
+        "display:inline-flex",
+        "align-items:center",
+        "justify-content:center",
+        "width:#{width_css}",
+        "height:#{height_css}",
+        "flex-shrink:0"
+      ].join(";")
+
+      style_attribute = [default_style, custom_style].compact.join(";")
 
       # Additional HTML attributes
-      attrs = options.except(:width, :height, :class, "width", "height", "class")
+      attrs = options.except(:width, :height, :class, :style, "width", "height", "class", "style")
 
       content_tag("rails-pulse-icon",
         "",
@@ -29,13 +45,29 @@ def rails_pulse_icon(name, options = {})
           'rails-pulse--icon-height-value': height
         },
         class: css_class,
+        style: style_attribute,
         **attrs
       )
     end
 
     # Backward compatibility alias - can be removed after migration
     alias_method :lucide_icon, :rails_pulse_icon
 
+    def normalize_dimension(value)
+      string = value.to_s
+      return string if string.empty?
+
+      if string.match?(/[a-z%]+\z/i)
+        string
+      else
+        number = Float(string)
+        formatted = number == number.to_i ? number.to_i.to_s : number.to_s
+        "#{formatted}px"
+      end
+    end
+
+    private :normalize_dimension
+
     # Make Rails Pulse routes available as rails_pulse in views
     def rails_pulse
       @rails_pulse_helper ||= RailsPulseHelper.new(self)

app/views/layouts/rails_pulse/application.html.erb

@@ -10,6 +10,29 @@
 
     <%= yield :head %>
 
+    <script nonce="<%= rails_pulse_csp_nonce %>">
+      (function() {
+        var storageKey = 'color-scheme';
+        var root = document.documentElement;
+        var scheme = 'light';
+
+        try {
+          var stored = localStorage.getItem(storageKey);
+          if (stored === 'dark' || stored === 'light') {
+            scheme = stored;
+          } else if (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) {
+            scheme = 'dark';
+          }
+        } catch (error) {
+          if (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) {
+            scheme = 'dark';
+          }
+        }
+
+        root.setAttribute('data-color-scheme', scheme);
+      })();
+    </script>
+
     <!-- Rails Pulse Pre-compiled Assets (CSP-safe) -->
     <%= stylesheet_link_tag rails_pulse.asset_path('rails-pulse.css'), 'data-turbo-track': 'reload' %>
     <%= javascript_include_tag rails_pulse.asset_path('rails-pulse-icons.js'), 'data-turbo-track': 'reload', defer: true, nonce: rails_pulse_csp_nonce %>

public/rails-pulse-assets/rails-pulse.css

@@ -11,6 +11,7 @@ class RailsPulse::ApplicationHelperTest < ActionView::TestCase
     assert_includes html, "rails-pulse--icon-name-value=\"alert\""
     assert_includes html, "rails-pulse--icon-width-value=\"24\""
     assert_includes html, "rails-pulse--icon-height-value=\"24\""
+    assert_includes html, "style=\"display:inline-flex;align-items:center;justify-content:center;width:24px;height:24px;flex-shrink:0\""
   end
 
   test "rails_pulse_icon applies custom width, height and class" do
@@ -19,6 +20,13 @@ class RailsPulse::ApplicationHelperTest < ActionView::TestCase
     assert_includes html, "rails-pulse--icon-width-value=\"32\""
     assert_includes html, "rails-pulse--icon-height-value=\"32\""
     assert_includes html, "class=\"my-class\""
+    assert_includes html, "width:32px;height:32px"
+  end
+
+  test "rails_pulse_icon merges custom style with default dimensions" do
+    html = rails_pulse_icon("alert", style: "margin-left:4px")
+
+    assert_includes html, "flex-shrink:0;margin-left:4px"
   end
 
   test "rails_pulse_icon passes through extra attributes" do

public/rails-pulse-assets/rails-pulse.js

@@ -24,9 +24,9 @@ class JobTest < ActiveSupport::TestCase
       job = Job.create!(name: "RailsPulse::TestJob", queue_name: "default")
       run = job.runs.create!(run_id: "test-run-1", status: "running", occurred_at: Time.current, attempts: 0)
 
-      run.update!(status: "retried", duration: 200.0)
+      run.update_columns(status: "retried", duration: 200.0)
 
-      job.apply_run!(run)
+      job.apply_run!(run.reload)
       job.reload
 
       assert_in_delta 200.0, job.avg_duration, 0.01

test/helpers/rails_pulse/application_helper_test.rb

@@ -9,6 +9,7 @@ class RailsPulse::SummaryTest < ActiveSupport::TestCase
     assert belong_to(:summarizable).optional.matches?(RailsPulse::Summary.new)
     assert belong_to(:route).optional.matches?(RailsPulse::Summary.new)
     assert belong_to(:query).optional.matches?(RailsPulse::Summary.new)
+    assert belong_to(:job).optional.matches?(RailsPulse::Summary.new)
   end
 
   # Test validations
@@ -47,7 +48,7 @@ class RailsPulse::SummaryTest < ActiveSupport::TestCase
   end
 
   test "should include ransackable associations" do
-    expected_associations = %w[route query]
+    expected_associations = %w[job query route]
 
     assert_equal expected_associations.sort, RailsPulse::Summary.ransackable_associations.sort
   end

test/models/rails_pulse/job_test.rb

@@ -14,7 +14,7 @@ def initialize(job_id: SecureRandom.uuid, queue_name: "default", executions: 0)
       end
 
       def self.name
-        "RailsPulse::JobRunCollectorTest::FakeJob"
+        "JobRunCollectorFakeJob"
       end
 
       def arguments
@@ -82,7 +82,7 @@ def enqueued_at
     end
 
     test "active job integration wraps perform now" do
-      class InstrumentedJob < ActiveJob::Base
+      klass = Class.new(ActiveJob::Base) do
         queue_as :default
 
         def perform
@@ -92,21 +92,29 @@ def perform
         end
       end
 
-      assert_difference -> { RailsPulse::Job.where(name: "RailsPulse::JobRunCollectorTest::InstrumentedJob").count }, 1 do
+      if Object.const_defined?(:JobRunCollectorTestInstrumentedJob)
+        Object.send(:remove_const, :JobRunCollectorTestInstrumentedJob)
+      end
+
+      Object.const_set(:JobRunCollectorTestInstrumentedJob, klass)
+
+      assert_difference -> { RailsPulse::Job.where(name: JobRunCollectorTestInstrumentedJob.name).count }, 1 do
         assert_difference -> { RailsPulse::JobRun.count }, 1 do
-          InstrumentedJob.perform_now
+          JobRunCollectorTestInstrumentedJob.perform_now
         end
       end
 
-      job = RailsPulse::Job.find_by(name: "RailsPulse::JobRunCollectorTest::InstrumentedJob")
+      job = RailsPulse::Job.find_by(name: JobRunCollectorTestInstrumentedJob.name)
 
       assert_not_nil job
       run = job.runs.order(:created_at).last
 
       assert_equal "success", run.status
       assert_not_empty RailsPulse::Operation.where(job_run: run)
     ensure
-      Object.send(:remove_const, :InstrumentedJob) if defined?(InstrumentedJob)
+      if Object.const_defined?(:JobRunCollectorTestInstrumentedJob)
+        Object.send(:remove_const, :JobRunCollectorTestInstrumentedJob)
+      end
     end
   end
 end