Skip to content

Conversation

@nathanfallet
Copy link
Contributor

@michaelklishin
Copy link
Contributor

@nathanfallet thank you for your ongoing contributions!

@michaelklishin
Copy link
Contributor

Just to clarify a couple of things:

  1. Moving an existing Kotlin tutorial that uses the Java client is perfectly fine
  2. Committing things like generated Gradle or Maven wrappers into this repo is also fine

However, I'm afraid these days we have to ask you @nathanfallet to sign our contributor CLA. It's under two pages long and uses a legally binding digital signing service.

@nathanfallet nathanfallet marked this pull request as ready for review November 27, 2025 19:30
@nathanfallet nathanfallet changed the title wip: new kotlin tutorials new kotlin tutorials Nov 27, 2025
@nathanfallet
Copy link
Contributor Author

@michaelklishin I'm doing this right now (for the CLA; I just sent the email request).

For the points you mentioned:

  1. Yeah we already validate that before
  2. The gradle wrapper is expected to be part of the repo, it's the base that downloads the appropriate Gradle distribution for the user (on their local machine in their home .gradle folder) so that they can build the project. Every gradle project has it included in the git.

Also, PR is ready, I'll edit the message when CLA is signed.

@michaelklishin
Copy link
Contributor

@nathanfallet sorry, I cannot find your request. Can you please resend?

@nathanfallet
Copy link
Contributor Author

nathanfallet commented Nov 28, 2025

You're right, just verified it was the wrong email (a ".dot." was left at the wrong place). Just resent!

EDIT: It's signed!

@michaelklishin michaelklishin merged commit 2c54f1b into rabbitmq:main Nov 28, 2025
@nathanfallet nathanfallet deleted the new-kotlin-tutorials branch November 28, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants