Skip to content

Commit c3cc7be

Browse files
Pat Mellonsoumith
authored andcommitted
Address hub page card issues
1 parent c0a71c1 commit c3cc7be

File tree

3 files changed

+45
-41
lines changed

3 files changed

+45
-41
lines changed

_sass/hub.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@
175175

176176
.hub .card-body {
177177
.hub-card-title-container {
178+
width: 75%;
178179
display: inline-flex;
179180
.experimental-badge {
180181
text-transform: uppercase;
@@ -353,13 +354,15 @@
353354
}
354355

355356
.hub .hub-card {
356-
height: auto;
357+
overflow: scroll;
357358
@include max-width-desktop {
358359
height: 150px;
360+
overflow: inherit;
359361
}
360362

361363
@include small-desktop {
362364
height: 170px;
365+
overflow: inherit;
363366
}
364367
}
365368

assets/hub-buttons.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ var numberOfCardsToShow = 3;
22

33
$(".cards-left > .col-md-12, .cards-right > .col-md-12")
44
.filter(function() {
5-
return $(this).attr("data-item-count") > numberOfCardsToShow.toString();
5+
return $(this).attr("data-item-count") > numberOfCardsToShow;
66
})
77
.hide();
88

@@ -34,7 +34,7 @@ function hideCards(buttonToHide, buttonToShow, cardsWrapper) {
3434
$(buttonToShow).show();
3535
$(cardsWrapper)
3636
.filter(function() {
37-
return $(this).attr("data-item-count") !== numberOfCardsToShow.toString();
37+
return $(this).attr("data-item-count") > numberOfCardsToShow;
3838
})
3939
.hide();
4040
}

hub.html

Lines changed: 39 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -72,34 +72,34 @@ <h3 class="research-hub-sub-title">Explore and extend models<br> from the latest
7272

7373
<hr>
7474

75-
<div class="row hub-cards-wrapper">
75+
<div class="row hub-cards-wrapper cards-left">
7676
{% assign hub = site.hub | where: "category", "researchers" | sort: "order" %}
7777

78-
<div class="cards-left">
79-
{% for item in hub %}
80-
<div class="col-md-12 research-hub-card-wrapper" data-item-count="{{ forloop.index }}" data-tags="{{ item.tags | join: ',' }}">
81-
<div class="card hub-card">
82-
<a href="{{ site.baseurl }}{{ item.url }}">
83-
<div class="card-body">
84-
<div class="hub-card-title-container">
85-
<h4>{{ item.title }}</h4>
86-
</div>
87-
<p class="card-summary">{{ item.summary }}</p>
88-
<div class="hub-image">
89-
<img src="{{ site.baseurl }}/assets/images/{{ item.image }}">
90-
</div>
78+
{% for item in hub %}
79+
<div class="col-md-12 research-hub-card-wrapper" data-item-count="{{ forloop.index }}" data-tags="{{ item.tags | join: ',' }}">
80+
<div class="card hub-card">
81+
<a href="{{ site.baseurl }}{{ item.url }}">
82+
<div class="card-body">
83+
<div class="hub-card-title-container">
84+
<h4>{{ item.title }}</h4>
9185
</div>
92-
</a>
93-
</div>
86+
<p class="card-summary">{{ item.summary }}</p>
87+
<div class="hub-image">
88+
<img src="{{ site.baseurl }}/assets/images/{{ item.image }}">
89+
</div>
90+
</div>
91+
</a>
9492
</div>
95-
{% endfor %}
96-
</div>
93+
</div>
94+
{% endfor %}
9795

98-
<div class="col-md-12">
96+
</div>
97+
98+
<div class="row">
99+
<div class="col-md-12 buttons-container">
99100
<button class="all-models-button" id="research-models">All Research Models ({{ hub | size}})</button>
100101
<button class="all-models-button" id="research-models-hide">Fewer Research Models</button>
101102
</div>
102-
103103
</div>
104104
</div>
105105

@@ -153,29 +153,30 @@ <h5 class="coming-soon">Coming Soon</h5>
153153
154154
<hr>
155155
156-
<div class="row hub-cards-wrapper">
156+
<div class="row hub-cards-wrapper cards-right">
157157
{% assign hub = site.hub | where: "category", "developers" | sort: "order" %}
158158
159-
<div class="cards-right">
160-
{% for item in hub %}
161-
<div class="col-md-12 hub-card-wrapper" data-item-count="{{ forloop.index }}" data-right-tags="{{ item.tags | join: ',' }}">
162-
<div class="card hub-card">
163-
<a href="{{ site.baseurl }}{{ item.url }}">
164-
<div class="card-body">
165-
<div class="hub-card-title-container">
166-
<h4>{{ item.title }} </h4>
167-
</div>
168-
<p class="card-summary">{{ item.summary }}</p>
169-
<div class="hub-image">
170-
<img src="{{ site.baseurl }}/assets/images/{{ item.image }}">
171-
</div>
159+
{% for item in hub %}
160+
<div class="col-md-12 hub-card-wrapper" data-item-count="{{ forloop.index }}" data-right-tags="{{ item.tags | join: ',' }}">
161+
<div class="card hub-card">
162+
<a href="{{ site.baseurl }}{{ item.url }}">
163+
<div class="card-body">
164+
<div class="hub-card-title-container">
165+
<h4>{{ item.title }} </h4>
166+
</div>
167+
<p class="card-summary">{{ item.summary }}</p>
168+
<div class="hub-image">
169+
<img src="{{ site.baseurl }}/assets/images/{{ item.image }}">
172170
</div>
173-
</a>
174-
</div>
171+
</div>
172+
</a>
175173
</div>
176-
{% endfor %}
177-
</div>
174+
</div>
175+
{% endfor %}
178176
177+
</div>
178+
179+
<div class="row">
179180
<div class="col-md-12">
180181
<button class="all-models-button" id="development-models">All Development Models ({{ hub | size}})</button>
181182
<button class="all-models-button" id="development-models-hide">Fewer Development Models</button>

0 commit comments

Comments
 (0)