From e10691e14ab73cdc271b96a6797a09b81ae78751 Mon Sep 17 00:00:00 2001 From: Alok Kumar Jha <92216931+akjalok@users.noreply.github.com> Date: Thu, 1 Jun 2023 12:01:06 +0530 Subject: [PATCH 1/5] changed the loss init to make it less confusing --- intermediate_source/char_rnn_generation_tutorial.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intermediate_source/char_rnn_generation_tutorial.py b/intermediate_source/char_rnn_generation_tutorial.py index 6068c84cd0e..defcc0fe893 100644 --- a/intermediate_source/char_rnn_generation_tutorial.py +++ b/intermediate_source/char_rnn_generation_tutorial.py @@ -278,7 +278,7 @@ def train(category_tensor, input_line_tensor, target_line_tensor): rnn.zero_grad() - loss = 0 + loss = torch.Tensor([0]) for i in range(input_line_tensor.size(0)): output, hidden = rnn(category_tensor, input_line_tensor[i], hidden) From f37deb071cec665c51e210dcd688140af7841516 Mon Sep 17 00:00:00 2001 From: Nicolas Hug Date: Fri, 2 Jun 2023 13:06:37 +0100 Subject: [PATCH 2/5] Update intermediate_source/char_rnn_generation_tutorial.py --- intermediate_source/char_rnn_generation_tutorial.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intermediate_source/char_rnn_generation_tutorial.py b/intermediate_source/char_rnn_generation_tutorial.py index defcc0fe893..b880d409bf6 100644 --- a/intermediate_source/char_rnn_generation_tutorial.py +++ b/intermediate_source/char_rnn_generation_tutorial.py @@ -278,7 +278,7 @@ def train(category_tensor, input_line_tensor, target_line_tensor): rnn.zero_grad() - loss = torch.Tensor([0]) + loss = torch.tensor([0]) for i in range(input_line_tensor.size(0)): output, hidden = rnn(category_tensor, input_line_tensor[i], hidden) From 85bc5d72a68751fd169388d8b1199d71dc9ff571 Mon Sep 17 00:00:00 2001 From: Svetlana Karslioglu Date: Fri, 2 Jun 2023 07:31:24 -0700 Subject: [PATCH 3/5] Update intermediate_source/char_rnn_generation_tutorial.py --- intermediate_source/char_rnn_generation_tutorial.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intermediate_source/char_rnn_generation_tutorial.py b/intermediate_source/char_rnn_generation_tutorial.py index b880d409bf6..60638291527 100644 --- a/intermediate_source/char_rnn_generation_tutorial.py +++ b/intermediate_source/char_rnn_generation_tutorial.py @@ -278,7 +278,7 @@ def train(category_tensor, input_line_tensor, target_line_tensor): rnn.zero_grad() - loss = torch.tensor([0]) + loss = torch.tensor([0]) # in PyTorch 2.0 and later can be don't need to initialize as tensor, can be ``loss = 0`` for i in range(input_line_tensor.size(0)): output, hidden = rnn(category_tensor, input_line_tensor[i], hidden) From 2176837c293924f7a460d6a12baec41988bc7774 Mon Sep 17 00:00:00 2001 From: Svetlana Karslioglu Date: Fri, 2 Jun 2023 07:38:57 -0700 Subject: [PATCH 4/5] Update intermediate_source/char_rnn_generation_tutorial.py --- intermediate_source/char_rnn_generation_tutorial.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intermediate_source/char_rnn_generation_tutorial.py b/intermediate_source/char_rnn_generation_tutorial.py index 60638291527..dd318698480 100644 --- a/intermediate_source/char_rnn_generation_tutorial.py +++ b/intermediate_source/char_rnn_generation_tutorial.py @@ -278,7 +278,7 @@ def train(category_tensor, input_line_tensor, target_line_tensor): rnn.zero_grad() - loss = torch.tensor([0]) # in PyTorch 2.0 and later can be don't need to initialize as tensor, can be ``loss = 0`` + loss = torch.tensor([0]) # you can also just simply use ``loss = 0`` for i in range(input_line_tensor.size(0)): output, hidden = rnn(category_tensor, input_line_tensor[i], hidden) From 0ec1b925dd7000cbc809fa187d9aa06d99e4aa93 Mon Sep 17 00:00:00 2001 From: Nicolas Hug Date: Fri, 2 Jun 2023 16:27:05 +0100 Subject: [PATCH 5/5] Update intermediate_source/char_rnn_generation_tutorial.py --- intermediate_source/char_rnn_generation_tutorial.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intermediate_source/char_rnn_generation_tutorial.py b/intermediate_source/char_rnn_generation_tutorial.py index dd318698480..d0c1c553865 100644 --- a/intermediate_source/char_rnn_generation_tutorial.py +++ b/intermediate_source/char_rnn_generation_tutorial.py @@ -278,7 +278,7 @@ def train(category_tensor, input_line_tensor, target_line_tensor): rnn.zero_grad() - loss = torch.tensor([0]) # you can also just simply use ``loss = 0`` + loss = torch.Tensor([0]) # you can also just simply use ``loss = 0`` for i in range(input_line_tensor.size(0)): output, hidden = rnn(category_tensor, input_line_tensor[i], hidden)