Skip to content

💡 [REQUEST] - <GETTING STARTED WITH FULLY SHARDED DATA PARALLEL(FSDP)> #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wesleystormrage opened this issue Oct 20, 2023 · 4 comments · Fixed by #2644
Closed

💡 [REQUEST] - <GETTING STARTED WITH FULLY SHARDED DATA PARALLEL(FSDP)> #2613

Wesleystormrage opened this issue Oct 20, 2023 · 4 comments · Fixed by #2644

Comments

@Wesleystormrage
Copy link

Wesleystormrage commented Oct 20, 2023

🚀 Descirbe the improvement or the new tutorial

After I read the "How FSDP works" in https://pytorch.org/tutorials/intermediate/FSDP_tutorial.html?highlight=fsdp, I still couldn't figure out what FSDP is due to the lack of explaination of ALL_GATHER and REDUCE-SCATTER which I believe are the key concepts in FSDP.
And this article helped me. https://engineering.fb.com/2021/07/15/open-source/fsdp/

"I believe The key insight to unlock full parameter sharding is that we can decompose the all-reduce operations in DDP into separate reduce-scatter and all-gather operations:"
image

I think adding this part can greatly help readers to better understand FSDP.

Existing tutorials on this topic

GETTING STARTED WITH FULLY SHARDED DATA PARALLEL(FSDP)
https://pytorch.org/tutorials/intermediate/FSDP_tutorial.html?highlight=fsdp

Additional context

No response

cc @wconstab @osalpekar @H-Huang @kwen2501 @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

@svekars
Copy link
Contributor

svekars commented Oct 25, 2023

@osalpekar @H-Huang @kwen2501 - any thoughts on the above?

@ChanBong
Copy link
Contributor

ChanBong commented Nov 1, 2023

/assigntome

@H-Huang
Copy link
Member

H-Huang commented Nov 2, 2023

I think adding that diagram in the introduction of the tutorial (or a link to the article) is fine to me. cc @awgu

@awgu
Copy link
Contributor

awgu commented Nov 2, 2023

I think adding that diagram in the introduction of the tutorial (or a link to the article) is fine to me. cc @awgu

Adding this figure sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants