Skip to content

Update tutorial to avoid use of copy.deepcopy()-Train a Mario-playing RL Agent #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sekyondaMeta opened this issue May 22, 2023 · 8 comments · Fixed by #2649
Closed

Update tutorial to avoid use of copy.deepcopy()-Train a Mario-playing RL Agent #2335

sekyondaMeta opened this issue May 22, 2023 · 8 comments · Fixed by #2649
Assignees
@alperenunlu
Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h2-2023 easy

Comments

@sekyondaMeta
Copy link
Contributor

sekyondaMeta commented May 22, 2023 •
edited by pytorch-bot bot
Loading

Update the Mario Playing RL Agent code to avoid the use of copy.deepcopy().

Tutorial link:

tutorials/intermediate_source/mario_rl_tutorial.py

Line 437 in 6ae56a1

self.target = copy.deepcopy(self.online)

See issue #2177 for more information

cc @albanD @svekars @carljparker @NicolasHug @kit1980 @subramen
@carljparker carljparker mentioned this issue May 26, 2023
Closed
@svekars svekars added core Tutorials of any level of difficulty related to the core pytorch functionality easy docathon-h1-2023 A label for the docathon in H1 2023 labels May 30, 2023
@nickKyr
Copy link

nickKyr commented May 31, 2023

/assigntome

@HemanthSai7
Copy link
Contributor

I would like to work on this issue if not completed.

@nickKyr
Copy link

nickKyr commented Jun 11, 2023

go for it!

@HemanthSai7
Copy link
Contributor

/assigntome

@github-actions
Copy link

The issue is already assigned. Please pick an opened and unnasigned issue with the docathon-h1-2023 label.

@HemanthSai7
Copy link
Contributor

@svekars Can I create a PR even though it isn't assigned to me? I have made the changes avoiding deepcopy.

@svekars
Copy link
Contributor

svekars commented Oct 6, 2023

@HemanthSai7 - sorry we missed your message - if you still want to send the PR, go for it - no need to assign.

@svekars svekars added docathon-h2-2023 and removed docathon-h1-2023 A label for the docathon in H1 2023 labels Oct 30, 2023
@alperenunlu
Copy link
Contributor

/assigntome

@saurabhkthakur saurabhkthakur mentioned this issue Nov 4, 2023
Closed
2 tasks
@alperenunlu alperenunlu mentioned this issue Nov 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alperenunlu alperenunlu

Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h2-2023 easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mario_rl_tutorial.py
updated the code to avoid deepcopy() saurabhkthakur/tutorials
5 participants
@svekars @HemanthSai7 @nickKyr @alperenunlu @sekyondaMeta