Skip to content

i2h<->h2h in gif #8750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2018
Merged

i2h<->h2h in gif #8750

merged 2 commits into from
Jun 21, 2018

Conversation

ssnl
Copy link
Collaborator

@ssnl ssnl commented Jun 21, 2018 •
edited
Loading

fixes pytorch/pytorch.github.io#34
fixes #1413

for future reference, this is procedure:

1. duplicate last frame to make it last 5 frames (so the total number of frames should be 11)
2. convert -resize 720x404 -delay 100 -loop 0 *.jpeg dynamic_graph.gif

@ssnl ssnl changed the title i2h<->h2h i2h<->h2h in gif Jun 21, 2018
@ssnl ssnl closed this Jun 21, 2018
@vishwakftw
Copy link
Contributor

@ssnl this issue could also be closed with this fix #1413 .

@ssnl ssnl reopened this Jun 21, 2018
@soumith soumith merged commit be3d65a into pytorch:master Jun 21, 2018
@ssnl ssnl deleted the new_gif branch June 21, 2018 18:56
@ezyang
Copy link
Contributor

ezyang commented Jun 22, 2018

lol, assembling a gif from jpegs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumith soumith soumith approved these changes

@zou3519 zou3519 zou3519 approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@zdevito zdevito Awaiting requested review from zdevito

Assignees
No one assigned
Labels
open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic graph gif- switch i2h and h2h cells? The GIF example on http://pytorch.org/about/ seems to have a couple of mistakes in it
5 participants
@ssnl @vishwakftw @ezyang @soumith @zou3519