Skip to content

Commit cc79268

Browse files
author
Jonatas Baldin
authored
Merge pull request #55 from jonatasbaldin/more-info
Add information about tests, scrapping and a Pull Request Template file
2 parents db9a8a7 + 618dbc2 commit cc79268

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed

.github/pull_request_template.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
## Hey there 👋
2+
First of all, thanks for opening this PR! The Python community appreciates ❤️🐍
3+
4+
## The Checklist (for communities) ✅
5+
We all love checklists, right? Please, make sure that the PR has everything we need:
6+
- [ ] The community is a local community, and not a conference. This is not a map for events in a certain point in time!
7+
- [ ] The community added has a `name`, `lat`, `lng` and `url`
8+
- [ ] The URL is working. No 404 pleeeeeeeeeease!
9+
- [ ] The tests are passing
10+
11+
## The Checklist (for other things) ✅
12+
We still don't have a process here, so:
13+
- [ ] The tests are passing 🤷‍♀️
14+
15+
❤️

README.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,21 @@ To get the latitude and longitude information, you can use [this](https://www.la
3636
### 3. Make a pull request
3737
At the end, create a pull request for this repository! You can find instructions [here](https://help.github.com/articles/creating-a-pull-request/).
3838
39+
## A note on scrapping
40+
> Personally, I want to avoid web scrapping to mass collect communities from other websites or repositories, because I'd like to see people adding the communities they _belong_ to. I think it creates a better sense of "putting yourself on the map" and also incentivise people to contribute to open source :)
41+
42+
## Testing
43+
To run the tests locally, you'll need NodeJS, probably version 8 or higher. I'm using v10.
44+
45+
Install everything:
46+
```
47+
$ npm install
48+
```
49+
50+
Run the tests:
51+
```
52+
$ npm test
53+
```
54+
3955
## License
4056
[MIT](https://github.com/jonatasbaldin/python-community-map/blob/master/LICENSE).

0 commit comments

Comments
 (0)