Skip to content

bpo-41902: Micro optimization for range.index if step is 1 #22479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2020
Merged

bpo-41902: Micro optimization for range.index if step is 1 #22479

merged 3 commits into from
Oct 21, 2020

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Oct 1, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 changed the title bpo-410902: Micro optimization for range.index if step is 1 bpo-41902: Micro optimization for range.index if step is 1 Oct 1, 2020
@corona10 corona10 requested a review from methane October 21, 2020 01:53
@corona10
Copy link
Member Author

corona10 commented Oct 21, 2020

@methane Can you please take a look also?

@corona10 corona10 merged commit c0f22fb into python:master Oct 21, 2020
@corona10 corona10 deleted the bpo-41902 branch October 21, 2020 02:30
vstinner
vstinner reviewed Oct 27, 2020
View reviewed changes
Objects/rangeobject.c
return NULL;
}

if (r->step == _PyLong_One) {
Copy link
Member

@vstinner vstinner Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, I made this check a little bit less efficient in commit c9bc290 to fix bpo-42161.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-41902: Micro optimization for range.index if step is 1 (pythonGH-…
44c9939 
…22479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@methane methane methane approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @vstinner @methane @the-knights-who-say-ni @bedevere-bot