From 27e68c899b7e3dc3c8a7049819e748a96b14d086 Mon Sep 17 00:00:00 2001 From: Sam Gross Date: Tue, 6 Jan 2026 16:02:24 -0500 Subject: [PATCH 1/2] gh-117657: Remove remaining TSan suppressions --- Tools/tsan/suppressions.txt | 3 --- Tools/tsan/suppressions_free_threading.txt | 13 ------------- 2 files changed, 16 deletions(-) diff --git a/Tools/tsan/suppressions.txt b/Tools/tsan/suppressions.txt index 6bda5ecd570889..efc6d92ab1ccf3 100644 --- a/Tools/tsan/suppressions.txt +++ b/Tools/tsan/suppressions.txt @@ -1,5 +1,2 @@ # This file contains suppressions for the default (with GIL) build. # reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions - -# https://gist.github.com/mpage/daaf32b39180c1989572957b943eb665 -thread:pthread_create diff --git a/Tools/tsan/suppressions_free_threading.txt b/Tools/tsan/suppressions_free_threading.txt index 581e9ef26f3c61..503f6463c5cddf 100644 --- a/Tools/tsan/suppressions_free_threading.txt +++ b/Tools/tsan/suppressions_free_threading.txt @@ -3,16 +3,3 @@ # the free-threaded build. # # reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions - -## Free-threaded suppressions - - -# These entries are for warnings that trigger in a library function, as called -# by a CPython function. - -# These warnings trigger directly in a CPython function. - -race_top:_PyObject_TryGetInstanceAttribute - -# https://gist.github.com/mpage/6962e8870606cfc960e159b407a0cb40 -thread:pthread_create From 2e39075f2ee192318f6148773cabcc805c60c300 Mon Sep 17 00:00:00 2001 From: Sam Gross Date: Wed, 7 Jan 2026 12:02:12 -0500 Subject: [PATCH 2/2] Add comment that suppression file is empty Also add instructions for adding new suppressions in case we need to do that in the future. --- Tools/tsan/suppressions.txt | 10 +++++++++- Tools/tsan/suppressions_free_threading.txt | 13 ++++++++++--- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/Tools/tsan/suppressions.txt b/Tools/tsan/suppressions.txt index efc6d92ab1ccf3..7a32f4e0ba26c5 100644 --- a/Tools/tsan/suppressions.txt +++ b/Tools/tsan/suppressions.txt @@ -1,2 +1,10 @@ # This file contains suppressions for the default (with GIL) build. -# reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions +# +# Reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions +# +# When adding a suppression, include a comment referencing a GitHub issue +# that describes how to reproduce the race and includes the relevant TSan +# output. + +# There are currently no active suppressions. This file is kept so tooling +# that expects it can still find it. diff --git a/Tools/tsan/suppressions_free_threading.txt b/Tools/tsan/suppressions_free_threading.txt index 503f6463c5cddf..f7ce11792e51b9 100644 --- a/Tools/tsan/suppressions_free_threading.txt +++ b/Tools/tsan/suppressions_free_threading.txt @@ -1,5 +1,12 @@ -# This file contains suppressions for the free-threaded build. It contains the -# suppressions for the default build and additional suppressions needed only in +# This file contains suppressions for the free-threaded build. It includes the +# default build suppressions plus any additional suppressions needed only in # the free-threaded build. # -# reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions +# Reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions +# +# When adding a suppression, include a comment referencing a GitHub issue +# that describes how to reproduce the race and includes the relevant TSan +# output. + +# There are currently no active suppressions. This file is kept so tooling +# that expects it can still find it.