Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Py_ExecutorDetach undefined when configured with --enable-experimental-jit=yes #131488

Closed
smontanaro opened this issue Mar 20, 2025 · 3 comments
Closed
Labels
type-bug An unexpected behavior, bug, or error

Comments

@smontanaro
Copy link
Contributor

smontanaro commented Mar 20, 2025

Bug report

Bug description:

My latest pull on main (~20:00 Central Daylight Time) broke my typical build. Configuring with no arguments works, but configuring with --enable-experimental-jit=yes causes a compilation error in Object/codeobject.c

gcc -c -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g -O3 -Wall    -D_Py_TIER2=1 -D_Py_JIT -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -Werror=unguarded-availability  -I./Include/internal -I./Include/internal/mimalloc  -I. -I./Include    -DPy_BUILD_CORE -o Objects/codeobject.o Objects/codeobject.c
Objects/codeobject.c:1700:13: error: call to undeclared function '_Py_ExecutorDetach'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
 1700 |             _Py_ExecutorDetach(co->co_executors->executors[i]);
      |             ^
1 error generated.
make: *** [Objects/codeobject.o] Error 1

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

@smontanaro smontanaro added the type-bug An unexpected behavior, bug, or error label Mar 20, 2025
@brandtbucher
Copy link
Member

brandtbucher commented Mar 20, 2025

I have a hunch this is due to the massive header refactoring over in GH-131238. JIT CI probably isn't running on those PRs.

@smontanaro
Copy link
Contributor Author

I have a hunch this is due to the massive header refactoring over in GH-131238. JIT CI probably isn't running on those PRs.

Yes, I got that impression skimming git log (without drilling down on the exact cause). It's no big deal for me. Just reporting the issue.

@smontanaro
Copy link
Contributor Author

Seems to be working (compiling and passing tests) once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants