Skip to content

Commit cd5a2bd

Browse files
committed
Issue #11852: Merge fix from 3.2.
2 parents b5a40d4 + e723e96 commit cd5a2bd

File tree

3 files changed

+20
-0
lines changed

3 files changed

+20
-0
lines changed

Lib/logging/handlers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626

2727
import logging, socket, os, pickle, struct, time, re
2828
from stat import ST_DEV, ST_INO, ST_MTIME
29+
import queue
30+
import threading
2931

3032
try:
3133
import codecs

Lib/test/test_logging.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import sys
4242
import tempfile
4343
from test.support import captured_stdout, run_with_locale, run_unittest, patch
44+
from test.support import TestHandler, Matcher
4445
import textwrap
4546
import unittest
4647
import warnings
@@ -2108,6 +2109,21 @@ def test_queue_handler(self):
21082109
self.assertEqual(data.name, self.que_logger.name)
21092110
self.assertEqual((data.msg, data.args), (msg, None))
21102111

2112+
def test_queue_listener(self):
2113+
handler = TestHandler(Matcher())
2114+
listener = logging.handlers.QueueListener(self.queue, handler)
2115+
listener.start()
2116+
try:
2117+
self.que_logger.warning(self.next_message())
2118+
self.que_logger.error(self.next_message())
2119+
self.que_logger.critical(self.next_message())
2120+
finally:
2121+
listener.stop()
2122+
self.assertTrue(handler.matches(levelno=logging.WARNING, message='1'))
2123+
self.assertTrue(handler.matches(levelno=logging.ERROR, message='2'))
2124+
self.assertTrue(handler.matches(levelno=logging.CRITICAL, message='3'))
2125+
2126+
21112127
class FormatterTest(unittest.TestCase):
21122128
def setUp(self):
21132129
self.common = {

Misc/NEWS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ Core and Builtins
110110
Library
111111
-------
112112

113+
- Issue #11852: Add missing imports and update tests.
114+
113115
- Issue #11467: Fix urlparse behavior when handling urls which contains scheme
114116
specific part only digits. Patch by Santoso Wijaya.
115117

0 commit comments

Comments
 (0)