Skip to content

Conversation

@pyrox0
Copy link
Contributor

@pyrox0 pyrox0 commented Jul 29, 2024

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

This PR is similar to pyexcel/pyexcel-ods#45, where the test infrastructure has been moved from the deprecated nose test runner to the modern pytest test runner. The same tests run, and they all pass. I made the least possible code changes to get the tests to pass.

@chfw chfw merged commit 00a660c into pyexcel:dev Nov 12, 2024
@chfw
Copy link
Member

chfw commented Nov 12, 2024

thank you very much for this migration! nose is not compatibile with python 3.10 onwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants