Skip to content

Unpin numpy #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Unpin numpy #959

merged 1 commit into from
Jun 21, 2023

Conversation

Zethson
Copy link
Contributor

@Zethson Zethson commented Jun 18, 2023

Fixes #958

Signed-off-by: zethson <lukas.heumos@posteo.net>
@emrekiciman
Copy link
Member

@kbattocchi @amit-sharma any reason not to unpin numpy? all the checks pass. Thanks

@emrekiciman
Copy link
Member

thanks @Zethson!

@amit-sharma
Copy link
Member

I think there was an issue with numba before where it was only compatible with lower versions of numpy. That is probably fixed now. @kbattocchi am I correct?

@kbattocchi
Copy link
Contributor

@amit-sharma: that's possible; as I recall there was an issue with numba that prevented us from supporting python 3.11 at one point on the econml side, but it looks like dowhy is limited to python<3.11 anyway. In general numpy releases have not posed backwards compatibility issues for econml so we have not added a constraint to a specific version.

@emrekiciman
Copy link
Member

All right. given your comments, @amit-sharma @kbattocchi and the passing checks, I'm going to go ahead and merge this in then!

Copy link
Member

@emrekiciman emrekiciman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (see conversation on this PR, with @amit-sharma and @kbattocchi on original reasons for pinning numpy)

@emrekiciman emrekiciman merged commit 4e0f64d into py-why:main Jun 21, 2023
@emrekiciman
Copy link
Member

@all-contributors please add @Zethson for code

@allcontributors
Copy link
Contributor

@emrekiciman

I've put up a pull request to add @Zethson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin numpy
4 participants