STY: Use zip for conciseness (#3027)

Also tweak an assert statement.

Author: j-t-1

pypdf/_utils.py

@@ -581,10 +581,10 @@ def __eq__(self, other: object) -> bool:
     def __lt__(self, other: Any) -> bool:
         if not isinstance(other, Version):
             raise ValueError(f"Version cannot be compared against {type(other)}")
-        min_len = min(len(self.components), len(other.components))
-        for i in range(min_len):
-            self_value, self_suffix = self.components[i]
-            other_value, other_suffix = other.components[i]
+
+        for self_component, other_component in zip(self.components, other.components):
+            self_value, self_suffix = self_component
+            other_value, other_suffix = other_component
 
             if self_value < other_value:
                 return True

tests/test_utils.py

@@ -353,22 +353,22 @@ def test_is_sublist():
         ("1", "1", False),
         ("1.0", "1.1", True),
         ("1", "1.1", True),
-        # suffix left
+        # Suffix left
         ("1a", "2", True),
         ("2a", "1", False),
         ("1a", "1", False),
         ("1.0a", "1.1", True),
-        # I'm not sure about that, but seems special enoguht that it
+        # I'm not sure about that, but seems special enough that it
         # probably doesn't matter:
         ("1a", "1.1", False),
-        # suffix right
+        # Suffix right
         ("1", "2a", True),
         ("2", "1a", False),
         ("1", "1a", True),
         ("1.0", "1.1a", True),
         ("1", "1.1a", True),
         ("", "0.0.0", True),
-        # just suffix matters ... hm, I think this is actually wrong:
+        # Just suffix matters ... hm, I think this is actually wrong:
         ("1.0a", "1.0", False),
         ("1.0", "1.0a", True),
     ],
@@ -379,7 +379,7 @@ def test_version_compare(left, right, is_less_than):
 
 def test_version_compare_equal_str():
     a = Version("1.0")
-    assert (a == "1.0") is False
+    assert a != "1.0"
 
 
 def test_version_compare_lt_str():