Count lines directly rather than using wc -l

Author: jawshooah

lib/overcommit/hook_context/run_all.rb

@@ -17,7 +17,7 @@ def modified_files
     # @return [Set]
     def modified_lines_in_file(file)
       @modified_lines_in_file ||= {}
-      @modified_lines_in_file[file] ||= Set.new(1..(count_lines(file) + 1))
+      @modified_lines_in_file[file] ||= Set.new(1..count_lines(file))
     end
 
     def hook_class_name
@@ -35,8 +35,9 @@ def hook_script_name
     private
 
     def count_lines(file)
-      result = Overcommit::Utils.execute(%w[wc -l] + [file])
-      result.success? ? result.stdout.to_i : 0
+      num_lines = 0
+      File.new(file).each_line { num_lines += 1 }
+      num_lines
     end
   end
 end

spec/overcommit/hook_context/run_all_spec.rb

@@ -67,7 +67,7 @@
         end
       end
 
-      it { should == Set.new(1..4) }
+      it { should == Set.new(1..3) }
     end
 
     context 'when file does not contain a trailing newline' do