Use double-quotes in shell commands

Windows command prompt does not recognize single-quotes as string
delimiters. Use double-quotes instead.

Author: jawshooah

lib/overcommit/git_repo.rb

@@ -69,7 +69,7 @@ def extract_modified_lines(file_path, options)
       refs = options[:refs]
       subcmd = options[:subcmd] || 'diff'
 
-      `git #{subcmd} --no-ext-diff -U0 #{flags} #{refs} -- '#{file_path}'`.
+      `git #{subcmd} --no-ext-diff -U0 #{flags} #{refs} -- "#{file_path}"`.
         scan(DIFF_HUNK_REGEX) do |start_line, lines_added|
         lines_added = (lines_added || 1).to_i # When blank, one line was added
         cur_line = start_line.to_i

lib/overcommit/hook/pre_commit/author_name.rb

@@ -8,7 +8,7 @@ def run
       unless name.split(' ').count >= 2
         return :fail,
                "Author must have at least first and last name, but was: #{name}." \
-               "\nSet your name with `git config --global user.name 'Your Name'`"
+               '\nSet your name with `git config --global user.name "Your Name"`'
       end
 
       :pass

lib/overcommit/hook_context/pre_commit.rb

@@ -20,7 +20,7 @@ def amendment?
         @amendment = !(/\s#{amend_pattern}/ =~ cmd).nil?
 
       # Check for git aliases that call `commit --amend`
-      `git config --get-regexp '^alias\\.' '#{amend_pattern}'`.
+      `git config --get-regexp "^alias\\." "#{amend_pattern}"`.
         scan(/alias\.([-\w]+)/). # Extract the alias
         each do |match|
           return @amendment if

spec/integration/committing_spec.rb

@@ -25,7 +25,7 @@
 
   context 'when a hook fails' do
     before do
-      `git config --local user.name ''`
+      `git config --local user.name ""`
     end
 
     it 'exits with a non-zero status' do
@@ -35,7 +35,7 @@
 
   context 'when no hooks fail' do
     before do
-      `git config --local user.name 'John Doe'`
+      `git config --local user.name "John Doe"`
     end
 
     it 'exits successfully' do

spec/overcommit/hook_context/post_commit_spec.rb

@@ -53,10 +53,10 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           `echo Hello > some-file`
           `git add some-file`
-          `git commit -m 'Modify some-file'`
+          `git commit -m "Modify some-file"`
           example.run
         end
       end
@@ -69,9 +69,9 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           `git rm some-file`
-          `git commit -m 'Delete some-file'`
+          `git commit -m "Delete some-file"`
           example.run
         end
       end

spec/overcommit/hook_context/post_merge_spec.rb

@@ -137,7 +137,7 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           `git checkout -b child > #{File::NULL} 2>&1`
           `echo Hello > some-file`
           `git add some-file`
@@ -156,7 +156,7 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           `git checkout -b child > #{File::NULL} 2>&1`
           `git rm some-file`
           `git commit -m "Branch commit"`

spec/overcommit/hook_context/pre_commit_spec.rb

@@ -23,8 +23,8 @@
     context 'when amending a commit using a git alias' do
       around do |example|
         repo do
-          `git config alias.amend 'commit --amend'`
-          `git config alias.other-amend 'commit --amend'`
+          `git config alias.amend "commit --amend"`
+          `git config alias.other-amend "commit --amend"`
           example.run
         end
       end
@@ -183,8 +183,8 @@
           `git submodule add #{submodule} sub > #{File::NULL} 2>&1`
           `git commit -m "Add submodule"`
           `echo "Hello World" > sub/submodule-file`
-          `git submodule foreach 'git add submodule-file'`
-          `git submodule foreach 'git commit -m "Another commit"'`
+          `git submodule foreach "git add submodule-file"`
+          `git submodule foreach "git commit -m \\"Another commit\\""`
           `git add sub`
           example.run
         end
@@ -333,8 +333,8 @@
           `git submodule add #{submodule} sub > #{File::NULL} 2>&1`
           `git commit -m "Add submodule"`
           `echo "Hello World" > sub/submodule-file`
-          `git submodule foreach 'git add submodule-file'`
-          `git submodule foreach 'git commit -m "Another commit"'`
+          `git submodule foreach "git add submodule-file"`
+          `git submodule foreach "git commit -m \\"Another commit\\""`
           `git add sub`
           example.run
         end
@@ -357,8 +357,8 @@
           `git submodule add #{submodule} sub > #{File::NULL} 2>&1`
           `git commit -m "Add submodule"`
           `echo "Hello World" > sub/submodule-file`
-          `git submodule foreach 'git add submodule-file'`
-          `git submodule foreach 'git commit -m "Another commit"'`
+          `git submodule foreach "git add submodule-file"`
+          `git submodule foreach "git commit -m \\"Another commit\\""`
           `echo "Hello Again" > tracked-file`
           `git add sub tracked-file`
           example.run
@@ -445,7 +445,7 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           `echo Hello > some-file`
           `git add some-file`
           example.run
@@ -460,7 +460,7 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           `git rm some-file`
           example.run
         end
@@ -474,7 +474,7 @@
         repo do
           FileUtils.touch('some-file')
           `git add some-file`
-          `git commit -m 'Initial commit'`
+          `git commit -m "Initial commit"`
           FileUtils.touch('other-file')
           `git add other-file`
           example.run