Skip to content

Commit 3571297

Browse files
committed
refactor: replace unary plus with Number for better readability in position calculations
1 parent 838d02e commit 3571297

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

src/components/Menu.vue

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -127,19 +127,6 @@ export default defineComponent({
127127
// resolve this component for usage innested menus
128128
const SubMenuComponent = resolveComponent('FloatMenu');
129129
130-
const selectMenuItem = (
131-
name?: string,
132-
id?: string,
133-
subMenu?: boolean,
134-
selectFirstItem?: boolean
135-
) => {
136-
if (!subMenu) {
137-
name && props?.onSelection(name);
138-
} else {
139-
toggleMenu(id, selectFirstItem);
140-
}
141-
};
142-
143130
// expands the submenu
144131
const toggleMenu = (id?: string, selectFirstItem?: boolean) => {
145132
menuItems.value = menuItems.value.map((item) =>
@@ -159,6 +146,19 @@ export default defineComponent({
159146
);
160147
};
161148
149+
const selectMenuItem = (
150+
name?: string,
151+
id?: string,
152+
subMenu?: boolean,
153+
selectFirstItem?: boolean
154+
) => {
155+
if (!subMenu) {
156+
name && props?.onSelection(name);
157+
} else {
158+
toggleMenu(id, selectFirstItem);
159+
}
160+
};
161+
162162
const handleMenuItemClick = (
163163
event: MouseEvent,
164164
id: string,
@@ -253,7 +253,7 @@ export default defineComponent({
253253
if (item.subMenu) {
254254
toggleMenu(item.id, true);
255255
} else {
256-
selectMenuItem(item.name, item.id, !!item.subMenu);
256+
selectMenuItem(item.name, item.id, Boolean(item.subMenu));
257257
}
258258
// handle right arrow
259259
} else if (keyCode === 'ArrowRight') {

src/components/index.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ export default defineComponent({
196196
const intialStyle = utils.setupInitStyle(props.position, props.dimension);
197197
198198
position.value = {
199-
left: +intialStyle.left.replace(/px/gi, ''),
200-
top: +intialStyle.top.replace(/px/gi, ''),
199+
left: Number(intialStyle.left.replace(/px/gi, '')),
200+
top: Number(intialStyle.top.replace(/px/gi, '')),
201201
};
202202
};
203203
@@ -232,8 +232,8 @@ export default defineComponent({
232232
// setup the initial style on load
233233
const intialStyle = utils.setupInitStyle(props.position, props.dimension);
234234
const initPosition = {
235-
left: +intialStyle.left.replace(/px/gi, ''),
236-
top: +intialStyle.top.replace(/px/gi, ''),
235+
left: Number(intialStyle.left.replace(/px/gi, '')),
236+
top: Number(intialStyle.top.replace(/px/gi, '')),
237237
};
238238
position.value = initPosition;
239239
previousPosition.value = initPosition;

0 commit comments

Comments
 (0)