Skip to content

Commit 975e365

Browse files
committed
Add "Returned with Feedback" and expand explanation of other patch statuses
1 parent 570b787 commit 975e365

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pgcommitfest/commitfest/templates/help.html

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,19 @@ <h2>Patches</h2>
2020
A "patch" is a bit of an overloaded term in the PostgreSQL community. Email threads on the mailing list often contain "patch files" as attachments, such a file is often referred to as a "patch". A single email can even contain multiple related "patch files", which are called a "patchset". However, in the context of a CommitFest app a "patch" usually means a "patch entry" in the CommitFest app. Such a "patch entry" is a reference to a mailinglist thread on which change to PostgreSQL has been proposed, by someone sending an email that contain one or more "patch files". The CommitFest app will automatically detect new versions of the patch files and update the "patch entry" accordingly.
2121
</p>
2222
<p>
23-
There are three active categories of patch status:
23+
There are three "Active" categories of patch status:
2424
<ul>
25-
<li>Waiting on Author - the author needs to make changes</li>
26-
<li>Needs Reviewer - the patch needs guidance or a review</li>
27-
<li>Ready for Committer - the patch is ready to be committed</li>
25+
<li><b>Waiting on Author:</b> The author needs to make changes based on a review that took place on the mailinglist.</li>
26+
<li><b>Needs Reviewer:</b> The patch needs guidance or a review.</li>
27+
<li><b>Ready for Committer:</b> The patch has been reviewed by non-committers and is considered ready to be committed by one of those reviewers. A committer might still decide that more changes are needed.</li>
2828
</ul>
29-
And there are three preferred inactive categories of patch status for when
30-
a patch has been resolved, either by being committed or not:
29+
And there four "Closed" categories of patch status for when a patch has been
30+
resolved, either by being committed or not:
3131
<ul>
32-
<li>Committed - a committer has applied the patches to the git repo</li>
33-
<li>Withdrawn - the author has withdrawn the patch from consideration</li>
34-
<li>Rejected - a committer has decided that the patch should not be applied</li>
32+
<li><b>Committed:</b> A committer has applied the patches to the git repo.</li>
33+
<li><b>Withdrawn:</b> The author has withdrawn the patch from consideration.</li>
34+
<li><b>Rejected:</b> A committer has decided that either the feature is not desired, or the design of the patch has severe flaws. People should look at the emails on the email thread, for details on why the patch was rejected.</li>
35+
<li><b>Returned with Feedback:</b> A committer has decided that the patch needs changes, but the author has not responded for long enough that the patch is now considered inactive. The author (or someoene else) is free to re-open again when they address the required changes.</li>
3536
</ul>
3637
</p>
3738

0 commit comments

Comments
 (0)