Remove deprecated instanceof Type checks

Author: hostep

src/bitExpert/PHPStan/Magento/Type/ObjectManagerDynamicReturnTypeExtension.php

@@ -64,9 +64,15 @@ public function getTypeFromMethodCall(
         /** @var \PhpParser\Node\Arg[] $args */
         $args = $methodCall->args;
         $argType = $scope->getType($args[0]->value);
-        if (!$argType instanceof ConstantStringType) {
+        if ($argType->getConstantStrings() === []) {
             return $mixedType;
         }
-        return TypeCombinator::addNull(new ObjectType($argType->getValue()));
+
+        $types = [];
+        foreach ($argType->getConstantStrings() as $constantString) {
+            $types[] = TypeCombinator::addNull(new ObjectType($constantString->getValue()));
+        }
+
+        return TypeCombinator::union(...$types);
     }
 }

src/bitExpert/PHPStan/Magento/Type/TestFrameworkObjectManagerDynamicReturnTypeExtension.php

@@ -92,10 +92,16 @@ private function getTypeForGetObjectMethodCall(
         /** @var \PhpParser\Node\Arg[] $args */
         $args = $methodCall->args;
         $argType = $scope->getType($args[0]->value);
-        if (!$argType instanceof ConstantStringType) {
+        if ($argType->getConstantStrings() === []) {
             return $mixedType;
         }
-        return TypeCombinator::addNull(new ObjectType($argType->getValue()));
+
+        $types = [];
+        foreach ($argType->getConstantStrings() as $constantString) {
+            $types[] = TypeCombinator::addNull(new ObjectType($constantString->getValue()));
+        }
+
+        return TypeCombinator::union(...$types);
     }
 
     /**