Skip to content

Commit a5f5067

Browse files
committed
Merge pull request #219 from plotly/fix-tests-on-master
Fix tests on master
2 parents 80ebeb7 + d0f7b1a commit a5f5067

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

circle.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@ test:
2727
# run test suite in all our python versions
2828
- bash circle/test.sh
2929

30-
# # test that it imports when you don't have file permissions
31-
# - sudo chmod 400 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"
32-
#
33-
# # test that setting permissions will work for import (and tests)
34-
# - sudo chmod 600 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"
30+
# test that it imports when you don't have write permissions
31+
- sudo chmod -R 444 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"
32+
33+
# test that giving back write permissions works again
34+
# this also has to pass the test suite that follows
35+
- sudo chmod -R 777 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"
3536

3637
# test core things in the general 2.7 version that circle has
37-
- nosetests -xv plotly/tests --with-coverage --cover-package=plotly
38+
- nosetests -xv plotly/tests/test_core --with-coverage --cover-package=plotly
3839
- mkdir "${CIRCLE_ARTIFACTS}/2.7" || true
3940
- coverage html -d "${CIRCLE_ARTIFACTS}/2.7" --title=2.7

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def readme():
4141
'plotly/matplotlylib/mplexporter',
4242
'plotly/matplotlylib/mplexporter/renderers'],
4343
package_data={'plotly': ['graph_reference/*.json', 'widgets/*.js']},
44-
install_requires=['requests', 'six', 'pytz'],
44+
install_requires=['requests[security]', 'six', 'pytz'],
4545
extras_require={"PY2.6": ['simplejson', 'ordereddict',
4646
'requests[security]']},
4747
zip_safe=False)

0 commit comments

Comments
 (0)