Skip to content

Sankey separator #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonerubiu opened this issue Jul 31, 2018 · 2 comments
Closed

Sankey separator #2859

simonerubiu opened this issue Jul 31, 2018 · 2 comments
Labels
bug something broken

Comments

@simonerubiu
Copy link

Hi there,
I need to set the decimal and thousands separators in sankey chart, I found out the layout.separators option that works for other kind of charts, but when I use this options in sankey nothing happen.
I think this is a bug, can you explain me how to fix this issue?? or if there is a branch where this issue is just resolved.

Thanks in advance ;)

@alexcjohnson alexcjohnson added the bug something broken label Jul 31, 2018
@alexcjohnson
Copy link
Collaborator

Thanks @simonerubiu - You're correct that our Sankey diagrams don't currently support layout.separators, and you're correct that this is a bug :)

Unfortunately our number formatting code is a bit chaotic at the moment, and ripe for refactoring... There's Lib.numSeparate that handles separators for simple floating-point representations, axes->numFormat that handles rounding and exponents along with separators but is tightly coupled to cartesian axes, and fullLayout._d3locale.numberFormat for using d3 format strings (including localization and override by layout.separators)

@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants