Tools (e.g. select) should not execute on contextmenu

[joshua-gould]

All tools (e.g. select) have their click handler invoked when right-clicking.

[etpinard]

Can I ask you why?

[joshua-gould]

I'd like to create a custom popup menu on right-click (contextmenu event)

[etpinard]

@joshua-gould I labelled this issue with the community tag meaning that the no plotly.js team member will dedicate time to it, but PR are welcomed to address this issue.

[AlexVvx]

Hi, guys. I pulled pr about context menu. When {rightClick: false} is in options, then 'contextmenu' event will be fired on element and default browser menu prevented. Please take a look at https://github.com/AlexVvx/plotly.js/pull/1/files

[alexcjohnson]

@AlexVvx interesting, thanks for the PR! I wonder though if there isn't a simpler solution - we probably don't really want to trigger dragelement if you right click no matter what. Can we just look at e.button and/or e.buttons and bail out of onStart if it's not a left-click? If we do that, your own contextmenu event handler should pick up the event, right?

I haven't looked at browser support of the button attributes - note that we target IE9+ in addition to current versions of Chrome, FF, Edge, and Safari.

Touch interactions are an interesting case, you generally get contextmenu on a long press there, right? But might this already work correctly, since in touch environments we don't create a coverSlip at all (which I'm assuming is what interferes with the expected contextMenu on desktop)?

[AlexVvx]

Sounds good, applied changes in new pr

[alexcjohnson]

closed by @AlexVvx in #2087