Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: espressif/arduino-esp32
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pillo79/arduino-esp32
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr-fix-digitalpintointerrupt-v3.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 25, 2024

  1. digitalPinToInterrupt: fix double pin remapping 

    The digitalPinToInterrupt() macro currently remaps the pin number to the
GPIO number. This is not necessary, as most users will then use the
returned value in attachInterrupt() or other similar API functions,
which already perform the same remapping.

The first half of the macro (the condition) does indeed require the
remapping to ensure the check operates on GPIO numbers.

Fixes #10367.
    @pillo79
    pillo79 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ccc07d9 View commit details
    Browse the repository at this point in the history
Loading