COMP: Fix warnings: deprecated conversion from string constant to ‘char*

Ideally, would be great if the python maintainer could update the
signature of the function to accept 'const char*' instead of 'char*'.

Author: jcfr

src/PythonQt.cpp

@@ -150,7 +150,7 @@ PythonQt::PythonQt(int flags, const QByteArray& pythonQtModuleName)
   _p->_PythonQtObjectPtr_metaId = qRegisterMetaType<PythonQtObjectPtr>("PythonQtObjectPtr");
 
   if ((flags & PythonAlreadyInitialized) == 0) {
-    Py_SetProgramName("PythonQt");
+    Py_SetProgramName(const_cast<char*>("PythonQt"));
     if (flags & IgnoreSiteModule) {
       // this prevents the automatic importing of Python site files
       Py_NoSiteFlag = 1;

src/PythonQtConversion.cpp

@@ -977,7 +977,8 @@ QVariant PythonQtConv::PyObjToQVariant(PyObject* val, int type)
     {
       if (PyMapping_Check(val)) {
         QMap<QString,QVariant> map;
-        PyObject* items = PyMapping_Items(val);
+        // PyObject* items = PyMapping_Items(val);
+        PyObject* items = PyObject_CallMethod(val, const_cast<char*>("items"), NULL);
         if (items) {
           int count = PyList_Size(items);
           PyObject* value;

src/PythonQtSlot.cpp

@@ -317,7 +317,7 @@ PythonQtSlotInfo*
 PythonQtSlotFunction_GetSlotInfo(PyObject *op)
 {
   if (!PythonQtSlotFunction_Check(op)) {
-    PyErr_BadInternalCall();
+    PyErr_Format(PyExc_SystemError, "%s:%d: bad argument to internal function", __FILE__, __LINE__);
     return NULL;
   }
   return ((PythonQtSlotFunctionObject *)op) -> m_ml;
@@ -327,7 +327,7 @@ PyObject *
 PythonQtSlotFunction_GetSelf(PyObject *op)
 {
   if (!PythonQtSlotFunction_Check(op)) {
-    PyErr_BadInternalCall();
+    PyErr_Format(PyExc_SystemError, "%s:%d: bad argument to internal function", __FILE__, __LINE__);
     return NULL;
   }
   return ((PythonQtSlotFunctionObject *)op) -> m_self;
@@ -392,9 +392,9 @@ meth_get__self__(PythonQtSlotFunctionObject *m, void * /*closure*/)
 }
 
 static PyGetSetDef meth_getsets [] = {
-  {"__doc__",  (getter)meth_get__doc__,  NULL, NULL},
-  {"__name__", (getter)meth_get__name__, NULL, NULL},
-  {"__self__", (getter)meth_get__self__, NULL, NULL},
+  {const_cast<char*>("__doc__"),  (getter)meth_get__doc__,  NULL, NULL},
+  {const_cast<char*>("__name__"), (getter)meth_get__name__, NULL, NULL},
+  {const_cast<char*>("__self__"), (getter)meth_get__self__, NULL, NULL},
   {NULL, NULL, NULL,NULL},
 };
 
@@ -405,7 +405,7 @@ static PyGetSetDef meth_getsets [] = {
 #define OFF(x) offsetof(PythonQtSlotFunctionObject, x)
 
 static PyMemberDef meth_members[] = {
-  {"__module__",    T_OBJECT,     OFF(m_module), PY_WRITE_RESTRICTED},
+  {const_cast<char*>("__module__"),    T_OBJECT,     OFF(m_module), PY_WRITE_RESTRICTED},
   {NULL}
 };
 

src/PythonQtStdDecorators.h

@@ -80,13 +80,13 @@ public slots:
 
   double static_Qt_qAbs(double a) { return qAbs(a); }
   double static_Qt_qBound(double a,double b,double c) { return qBound(a,b,c); }
-  void static_Qt_qDebug(const QByteArray& msg) { qDebug(msg.constData()); }
+  void static_Qt_qDebug(const QByteArray& msg) { qDebug("%s", msg.constData()); }
   // TODO: multi arg qDebug...
-  void static_Qt_qWarning(const QByteArray& msg) { qWarning(msg.constData()); }
+  void static_Qt_qWarning(const QByteArray& msg) { qWarning("%s", msg.constData()); }
   // TODO: multi arg qWarning...
-  void static_Qt_qCritical(const QByteArray& msg) { qCritical(msg.constData()); }
+  void static_Qt_qCritical(const QByteArray& msg) { qCritical("%s", msg.constData()); }
   // TODO: multi arg qCritical...
-  void static_Qt_qFatal(const QByteArray& msg) { qFatal(msg.constData()); }
+  void static_Qt_qFatal(const QByteArray& msg) { qFatal("%s", msg.constData()); }
   // TODO: multi arg qFatal...
   bool static_Qt_qFuzzyCompare(double a, double b) { return qFuzzyCompare(a, b); }
   double static_Qt_qMax(double a, double b) { return qMax(a, b); }

src/PythonQtStdOut.cpp

@@ -87,8 +87,8 @@ static PyMethodDef PythonQtStdOutRedirect_methods[] = {
 };
 
 static PyMemberDef PythonQtStdOutRedirect_members[] = {
-  {"softspace", T_INT, offsetof(PythonQtStdOutRedirect, softspace), 0,
-    "soft space flag"
+  {const_cast<char*>("softspace"), T_INT, offsetof(PythonQtStdOutRedirect, softspace), 0,
+    const_cast<char*>("soft space flag")
   },
   {NULL}  /* Sentinel */
 };