Specify type for Request::getSession based on pre-existing Request::hasSession - tests.

Author: pplotka

tests/Type/Symfony/RequestTypeSpecifyingExtensionTest.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Symfony;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPStan\Type\MethodTypeSpecifyingExtension;
+use Symfony\Component\HttpFoundation\Session\SessionInterface;
+
+final class RequestTypeSpecifyingExtensionTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new VariableTypeReportingRule();
+	}
+
+	/** @return MethodTypeSpecifyingExtension[] */
+	protected function getMethodTypeSpecifyingExtensions(): array
+	{
+		return [
+			new RequestTypeSpecifyingExtension(),
+		];
+	}
+
+	public function testGetSession(): void
+	{
+		$this->analyse([__DIR__ . '/request_get_session.php'], [
+			[
+				'Variable $session1 is: ' . SessionInterface::class . '|null',
+				11,
+			],
+			[
+				'Variable $session2 is: ' . SessionInterface::class,
+				13,
+			],
+		]);
+	}
+
+}

tests/Type/Symfony/VariableTypeReportingRule.php

@@ -0,0 +1,44 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Symfony;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\Variable;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Type\VerbosityLevel;
+
+final class VariableTypeReportingRule implements Rule
+{
+
+	public function getNodeType(): string
+	{
+		return Variable::class;
+	}
+
+	/**
+	 * @param Node $node
+	 * @param Scope $scope
+	 * @return (string|RuleError)[] errors
+	 */
+	public function processNode(Node $node, Scope $scope): array
+	{
+		if (!is_string($node->name)) {
+			return [];
+		}
+		if (!$scope->isInFirstLevelStatement()) {
+			return [];
+		};
+		if ($scope->isInExpressionAssign($node)) {
+			return [];
+		}
+		return [
+			sprintf(
+				'Variable $%s is: %s',
+				$node->name,
+				$scope->getType($node)->describe(VerbosityLevel::value())
+			),
+		];
+	}
+
+}

tests/Type/Symfony/request_get_session.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Symfony;
+
+use Symfony\Component\HttpFoundation\Request;
+
+class Foo {
+
+	public function doFoo(Request $request): void
+	{
+		$session1 = $request->getSession();
+		if ($request->hasSession()) {
+			$session2 = $request->getSession();
+		}
+	}
+
+}