Skip to content

Commit 16f3ed7

Browse files
committed
fix
1 parent 627f2be commit 16f3ed7

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/Reflection/BetterReflection/BetterReflectionProvider.php

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -373,9 +373,17 @@ public function getConstant(Node\Name $nameNode, ?NamespaceAnswerer $namespaceAn
373373
if ($resolvedPhpDoc->isDeprecated() && $resolvedPhpDoc->getDeprecatedTag() !== null) {
374374
$deprecatedMessage = $resolvedPhpDoc->getDeprecatedTag()->getMessage();
375375

376-
// filter raw version number messages like in
377-
// https://github.com/JetBrains/phpstorm-stubs/blob/9608c953230b08f07b703ecfe459cc58d5421437/filter/filter.php#L478
378-
if (Strings::match($deprecatedMessage ?? '', '#^\d+\.\d+(\.\d+)?$#') === null) {
376+
$matches = Strings::match($deprecatedMessage ?? '', '#^(\d+)\.(\d+)(?:\.(\d+))?$#');
377+
if ($matches !== null) {
378+
$major = $matches[1];
379+
$minor = $matches[2];
380+
$patch = $matches[3] ?? 0;
381+
$versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
382+
383+
$isDeprecated = TrinaryLogic::createFromBoolean($this->phpVersion->getVersionId() >= $versionId);
384+
} else {
385+
// filter raw version number messages like in
386+
// https://github.com/JetBrains/phpstorm-stubs/blob/9608c953230b08f07b703ecfe459cc58d5421437/filter/filter.php#L478
379387
$deprecatedDescription = $deprecatedMessage;
380388
}
381389
}

0 commit comments

Comments
 (0)