From d2b6dad1c8736f87de8f19e96897c5b3e80056b0 Mon Sep 17 00:00:00 2001 From: pascalc Date: Tue, 11 Dec 2012 16:28:16 +0100 Subject: [PATCH 1/4] update css for 404 pages to not look like we are in 1995 and have a consistent layout across browsers --- sapi/cli/php_cli_server.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c index d0d4cefb909e9..4a84a21c0818b 100644 --- a/sapi/cli/php_cli_server.c +++ b/sapi/cli/php_cli_server.c @@ -280,8 +280,9 @@ ZEND_DECLARE_MODULE_GLOBALS(cli_server); * copied from ext/standard/info.c */ static const char php_cli_server_css[] = "\n"; /* }}} */ From 3d04db7e92c109c40cb94d5790de8e93dd5556f1 Mon Sep 17 00:00:00 2001 From: pascalc Date: Tue, 11 Dec 2012 16:58:20 +0100 Subject: [PATCH 2/4] highlight the ressource that is 404 in the error message --- sapi/cli/php_cli_server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c index 4a84a21c0818b..95db347c0c981 100644 --- a/sapi/cli/php_cli_server.c +++ b/sapi/cli/php_cli_server.c @@ -246,7 +246,7 @@ static php_cli_server_http_reponse_status_code_pair status_map[] = { static php_cli_server_http_reponse_status_code_pair template_map[] = { { 400, "

%s

Your browser sent a request that this server could not understand.

" }, - { 404, "

%s

The requested resource %s was not found on this server.

" }, + { 404, "

%s

The requested resource %s was not found on this server.

" }, { 500, "

%s

The server is temporarily unavailable.

" }, { 501, "

%s

Request method not supported.

" } }; @@ -283,6 +283,7 @@ static const char php_cli_server_css[] = "\n"; /* }}} */ From c1f9ea0ba366914e63273acb7568994c84e644a9 Mon Sep 17 00:00:00 2001 From: pascalc Date: Fri, 11 Jan 2013 08:01:00 +0100 Subject: [PATCH 3/4] use lowercase HEX values in CSS --- sapi/cli/php_cli_server.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c index ec1059b8be00b..700a495258048 100644 --- a/sapi/cli/php_cli_server.c +++ b/sapi/cli/php_cli_server.c @@ -283,10 +283,10 @@ ZEND_DECLARE_MODULE_GLOBALS(cli_server); * copied from ext/standard/info.c */ static const char php_cli_server_css[] = "\n"; /* }}} */ From b7974a4cbc57725a911a89ba80437da498c97fbb Mon Sep 17 00:00:00 2001 From: pascalc Date: Tue, 11 Dec 2012 16:28:16 +0100 Subject: [PATCH 4/4] update css for 404 pages to not look like we are in 1995 and have a consistent layout across browsers highlight the ressource that is 404 in the error message use lowercase HEX values in CSS --- sapi/cli/php_cli_server.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c index 74d2ad2c3bd40..700a495258048 100644 --- a/sapi/cli/php_cli_server.c +++ b/sapi/cli/php_cli_server.c @@ -246,7 +246,7 @@ static php_cli_server_http_reponse_status_code_pair status_map[] = { static php_cli_server_http_reponse_status_code_pair template_map[] = { { 400, "

%s

Your browser sent a request that this server could not understand.

" }, - { 404, "

%s

The requested resource %s was not found on this server.

" }, + { 404, "

%s

The requested resource %s was not found on this server.

" }, { 500, "

%s

The server is temporarily unavailable.

" }, { 501, "

%s

Request method not supported.

" } }; @@ -283,8 +283,10 @@ ZEND_DECLARE_MODULE_GLOBALS(cli_server); * copied from ext/standard/info.c */ static const char php_cli_server_css[] = "\n"; /* }}} */