From 88350699a58fd83283126832ce436a6ae4b701b6 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Fri, 11 Jul 2025 00:08:38 +0200 Subject: [PATCH] dom: Remove unnecessary objmap ptr null checks This will be unnecessary once GH-19089 is merged because we always will have a valid objmap object. --- ext/dom/namednodemap.c | 4 ---- ext/dom/obj_map.c | 3 --- 2 files changed, 7 deletions(-) diff --git a/ext/dom/namednodemap.c b/ext/dom/namednodemap.c index 953731ad84487..ef527e2eabaa5 100644 --- a/ext/dom/namednodemap.c +++ b/ext/dom/namednodemap.c @@ -35,10 +35,6 @@ zend_long php_dom_get_namednodemap_length(dom_object *obj) { dom_nnodemap_object *objmap = obj->ptr; - if (!objmap) { - return 0; - } - return objmap->handler->length(objmap); } diff --git a/ext/dom/obj_map.c b/ext/dom/obj_map.c index 367171c43007e..c7d2a95125e56 100644 --- a/ext/dom/obj_map.c +++ b/ext/dom/obj_map.c @@ -294,9 +294,6 @@ static void dom_map_get_null_item(dom_nnodemap_object *map, zend_long index, zva zend_long php_dom_get_nodelist_length(dom_object *obj) { dom_nnodemap_object *objmap = obj->ptr; - if (!objmap) { - return 0; - } if (objmap->handler->use_cache) { xmlNodePtr nodep = dom_object_get_node(objmap->baseobj);