Add Windows GitHub actions build #10664
Conversation
run-tests.php
Outdated
| @@ -2781,7 +2781,9 @@ function run_test(string $php, $file, array $env): string | |||
| $orig_shortname = str_replace(TEST_PHP_SRCDIR . '/', '', $file); | |||
| $diff = "# original source file: $orig_shortname\n" . $diff; | |||
| } | |||
| show_file_block('diff', $diff); | |||
| if (!$SHOW_ONLY_GROUPS || array_intersect($restype, $SHOW_ONLY_GROUPS)) { | |||
There was a problem hiding this comment.
Thank you @iluuu1994 for taking #8392 over.
this/run-tests.php change is some rebase leftover- to discuss/merge test changes, please use Fix mysql tests with non-standard server port #9744
- do not forget to add nightly job one this PR is working
- please keep https://github.com/mvorisek/php-src/blob/fea5e38b3cadcd43199f3f5733308425cab606a1/.github/scripts/windows/test_task.bat#L3-L6 to prevent the CI .bat files to be run locally (there can mutate some system configuration when run locally by a mistake)
actions/cache, ex. https://github.com/atk4/core/blob/develop/.github/workflows/test-unit.yml#L34-L45, should be used to speed the CI- please also merge Fix compile for Windows x86 with /W1 /WX options (warnings are fatal) #8479 to make warning on x64/x86 fatal (to fail CI on problems)
There was a problem hiding this comment.
this/run-tests.php change is some rebase leftover
This is intentional, otherwise the -g flag doesn't behave properly (diff gets printed even if excluded). It's backported from master.
do not forget to add nightly job one this PR is working
It's removed intentionally for now until this has proven to work fine, I'll re-add it after.
|
There seems to be an issue with test |
iluuu1994
force-pushed
the
github-actions-windows
branch
2 times, most recently
from
b624e14 to
67ea7f9
Compare
|
Turns out |
iluuu1994
force-pushed
the
github-actions-windows
branch
15 times, most recently
from
c59ae3b to
1d7c35a
Compare
iluuu1994
force-pushed
the
github-actions-windows
branch
from
1d7c35a to
202216b
Compare
|
Unfortunately, it looks like sometimes the build stalls in the build phase ( https://github.com/php/php-src/actions/runs/4352459361/jobs/7605272205 |
at the end is caused by Github Actions tryiing to terminate the job step after timeout, so the problem is before to debug this, you may want to fork https://github.com/php/php-sdk-binary-tools/blob/master/bin/phpsdk_deps.php (cloned here https://github.com/php/php-src/blob/916b132ea0/.github/scripts/windows/build.bat#L23) and log more data |
#8392 with minimal changes.