Segfault when running Psalm with JIT on the official 8.3 alpine ZTS image

[danog]

Description

The following Dockerfile:

FROM php:8.3-zts-alpine AS base

COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/local/bin/

RUN install-php-extensions opcache

RUN apk add git unzip

RUN git clone https://github.com/WyriHaximus/php-test-utilities/ \
    && php -r "readfile('https://getcomposer.org/installer');" | php \
	&& mv composer.phar /usr/bin/composer 

WORKDIR /php-test-utilities
RUN composer install --ignore-platform-reqs || true

ENV PSALM_ALLOW_XDEBUG=1

RUN php -dopcache.enable_cli=true -dopcache.jit_buffer_size=64M -dopcache.jit=1205 -dopcache.optimization_level=0x7FFEBFFF vendor/bin/psalm --shepherd --stats --config=./etc/qa/psalm.xml --no-cache

ENTRYPOINT ["docker-php-entrypoint"]

Resulted in a segfault, but I expected no segfault.

Ping @dstogov @WyriHaximus @Girgias

PHP Version

PHP 8.3.0

Operating System

No response

[dstogov]

I see the problem. It's related to Thread Local Storage implementation in MUSL.

It seems like 2b2aeb9 fixed some compilation issues, but not the real TLS address calculation in JIT.
So JIT in ZTS build never worked with MUSL.
I suppose we need some special support for MUSL at

php-src/ext/opcache/jit/zend_jit_x86.dasc:2898
 #if defined(__has_attribute) && __has_attribute(tls_model) && !defined(__FreeBSD__) && !defined(__OpenBSD__) && !defined(__MUSL__) 

Most probably we should use 8 instead of 16 at

php-src/ext/opcache/jit/zend_jit_x86.dasc:2911

 tsrm_tls_index = ti[0] * 16; 

@danong can you test this?

[dstogov]

This should be fixed via 94ba883 and 71cccc0