Skip to content

Commit f005f36

Browse files
author
Ilia Alshanetsky
committed
Fixed bug #60634 (Segmentation fault when trying to die() in SessionHandler::write())
1 parent c9436c2 commit f005f36

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

NEWS

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ PHP NEWS
5252
. Fixed bug #60811 (php-fpm compilation problem). (rasmus)
5353

5454
- SOAP
55+
. Fixed basic HTTP authentication for WSDL sub requests. (Dmitry)
5556
. Fixed bug #60887 (SoapClient ignores user_agent option and sends no
5657
User-Agent header). (carloschilazo at gmail dot com)
5758

@@ -61,16 +62,15 @@ PHP NEWS
6162
- PDO_Sqlite extension:
6263
. Add createCollation support. (Damien)
6364

64-
- SOAP:
65-
. Fixed basic HTTP authentication for WSDL sub requests. (Dmitry)
66-
6765
- Reflection:
6866
. Fixed bug #60968 (Late static binding doesn't work with
6967
ReflectionMethod::invokeArgs()). (Laruence)
7068

7169
- Session:
7270
. Fixed bug #60860 (session.save_handler=user without defined function core
7371
dumps). (Felipe)
72+
. Fixed bug #60634 (Segmentation fault when trying to die() in
73+
SessionHandler::write()). (Ilia)
7474

7575
- Streams:
7676
. Fixed bug #61115 (stream related segfault on fatal error in

ext/session/session.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,9 +1512,7 @@ static void php_session_flush(TSRMLS_D) /* {{{ */
15121512
{
15131513
if (PS(session_status) == php_session_active) {
15141514
PS(session_status) = php_session_none;
1515-
zend_try {
1516-
php_session_save_current_state(TSRMLS_C);
1517-
} zend_end_try();
1515+
php_session_save_current_state(TSRMLS_C);
15181516
}
15191517
}
15201518
/* }}} */
@@ -2167,7 +2165,9 @@ static PHP_RSHUTDOWN_FUNCTION(session) /* {{{ */
21672165
{
21682166
int i;
21692167

2170-
php_session_flush(TSRMLS_C);
2168+
zend_try {
2169+
php_session_flush(TSRMLS_C);
2170+
} zend_end_try();
21712171
php_rshutdown_session_globals(TSRMLS_C);
21722172

21732173
/* this should NOT be done in php_rshutdown_session_globals() */

0 commit comments

Comments
 (0)