- MFH: Fixed code (comparison with string literal)

felipensp · felipensp · commit e13d011551e3 · 2008-12-27T19:06:48.000Z
diff --git a/ext/xmlrpc/xmlrpc-epi-php.c b/ext/xmlrpc/xmlrpc-epi-php.c
@@ -715,7 +715,7 @@ PHP_FUNCTION(xmlrpc_encode_request)
 		}
 	}
 	
-	if (out.xmlrpc_out.xml_elem_opts.encoding != ENCODING_DEFAULT) {
+	if (strcmp(out.xmlrpc_out.xml_elem_opts.encoding, ENCODING_DEFAULT) != 0) {
 		efree((char *)out.xmlrpc_out.xml_elem_opts.encoding);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -715,7 +715,7 @@ PHP_FUNCTION(xmlrpc_encode_request)`
`715`	`715`	`}`
`716`	`716`	`}`
`717`	`717`
`718`		`- if (out.xmlrpc_out.xml_elem_opts.encoding != ENCODING_DEFAULT) {`
	`718`	`+ if (strcmp(out.xmlrpc_out.xml_elem_opts.encoding, ENCODING_DEFAULT) != 0) {`
`719`	`719`	`efree((char *)out.xmlrpc_out.xml_elem_opts.encoding);`
`720`	`720`	`}`
`721`	`721`	`}`