Skip to content

Commit d5f7ffb

Browse files
committed
Merge branch 'PHP-8.1' into PHP-8.2
* PHP-8.1: Make unrepeatable tests retriable
2 parents a1043fe + f2c16b7 commit d5f7ffb

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

run-tests.php

+1-7
Original file line numberDiff line numberDiff line change
@@ -1807,7 +1807,6 @@ function run_test(string $php, $file, array $env): string
18071807
$skipCache = new SkipCache($enableSkipCache, $cfg['keep']['skip']);
18081808
}
18091809

1810-
$retriable = true;
18111810
$retried = false;
18121811
retry:
18131812

@@ -1851,7 +1850,6 @@ function run_test(string $php, $file, array $env): string
18511850
$tested = $test->getName();
18521851

18531852
if ($test->hasSection('FILE_EXTERNAL')) {
1854-
$retriable = false;
18551853
if ($num_repeats > 1) {
18561854
return skip_test($tested, $tested_file, $shortname, 'Test with FILE_EXTERNAL might not be repeatable');
18571855
}
@@ -1880,7 +1878,6 @@ function run_test(string $php, $file, array $env): string
18801878
}
18811879
$php = $php_cgi . ' -C ';
18821880
$uses_cgi = true;
1883-
$retriable = false;
18841881
if ($num_repeats > 1) {
18851882
return skip_test($tested, $tested_file, $shortname, 'CGI does not support --repeat');
18861883
}
@@ -1898,15 +1895,13 @@ function run_test(string $php, $file, array $env): string
18981895
} else {
18991896
return skip_test($tested, $tested_file, $shortname, 'phpdbg not available');
19001897
}
1901-
$retriable = false;
19021898
if ($num_repeats > 1) {
19031899
return skip_test($tested, $tested_file, $shortname, 'phpdbg does not support --repeat');
19041900
}
19051901
}
19061902

19071903
foreach (['CLEAN', 'STDIN', 'CAPTURE_STDIO'] as $section) {
19081904
if ($test->hasSection($section)) {
1909-
$retriable = false;
19101905
if ($num_repeats > 1) {
19111906
return skip_test($tested, $tested_file, $shortname, "Test with $section might not be repeatable");
19121907
}
@@ -2092,7 +2087,6 @@ function run_test(string $php, $file, array $env): string
20922087
settings2array(preg_split("/[\n\r]+/", $ini), $ini_settings);
20932088

20942089
if (isset($ini_settings['opcache.opt_debug_level'])) {
2095-
$retriable = false;
20962090
if ($num_repeats > 1) {
20972091
return skip_test($tested, $tested_file, $shortname, 'opt_debug_level tests are not repeatable');
20982092
}
@@ -2626,7 +2620,7 @@ function run_test(string $php, $file, array $env): string
26262620

26272621
$wanted_re = null;
26282622
}
2629-
if (!$passed && !$retried && $retriable && error_may_be_retried($test, $output)) {
2623+
if (!$passed && !$retried && error_may_be_retried($test, $output)) {
26302624
$retried = true;
26312625
goto retry;
26322626
}

0 commit comments

Comments
 (0)