Skip to content

Commit c890d46

Browse files
committed
Use array specific functions
1 parent 747a592 commit c890d46

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

sapi/cgi/cgi_main.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -672,8 +672,8 @@ static void cgi_php_import_environment_variables(zval *array_ptr)
672672

673673
if (Z_TYPE(PG(http_globals)[TRACK_VARS_ENV]) == IS_ARRAY &&
674674
Z_ARR_P(array_ptr) != Z_ARR(PG(http_globals)[TRACK_VARS_ENV])) {
675-
zval_dtor(array_ptr);
676-
ZVAL_DUP(array_ptr, &PG(http_globals)[TRACK_VARS_ENV]);
675+
zend_array_destroy(Z_ARR_P(array_ptr));
676+
Z_ARR_P(array_ptr) = zend_array_dup(Z_ARR(PG(http_globals)[TRACK_VARS_ENV]));
677677
return;
678678
}
679679

sapi/fpm/fpm/fpm_main.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -568,15 +568,15 @@ void cgi_php_import_environment_variables(zval *array_ptr) /* {{{ */
568568
Z_ARR_P(array_ptr) != Z_ARR(PG(http_globals)[TRACK_VARS_ENV]) &&
569569
zend_hash_num_elements(Z_ARRVAL(PG(http_globals)[TRACK_VARS_ENV])) > 0
570570
) {
571-
zval_dtor(array_ptr);
572-
ZVAL_DUP(array_ptr, &PG(http_globals)[TRACK_VARS_ENV]);
571+
zend_array_destroy(Z_ARR_P(array_ptr));
572+
Z_ARR_P(array_ptr) = zend_array_dup(Z_ARR(PG(http_globals)[TRACK_VARS_ENV]));
573573
return;
574574
} else if (Z_TYPE(PG(http_globals)[TRACK_VARS_SERVER]) == IS_ARRAY &&
575575
Z_ARR_P(array_ptr) != Z_ARR(PG(http_globals)[TRACK_VARS_SERVER]) &&
576576
zend_hash_num_elements(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER])) > 0
577577
) {
578-
zval_dtor(array_ptr);
579-
ZVAL_DUP(array_ptr, &PG(http_globals)[TRACK_VARS_SERVER]);
578+
zend_array_destroy(Z_ARR_P(array_ptr));
579+
Z_ARR_P(array_ptr) = zend_array_dup(Z_ARR(PG(http_globals)[TRACK_VARS_SERVER]));
580580
return;
581581
}
582582

sapi/litespeed/lsapi_main.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -244,15 +244,15 @@ static void litespeed_php_import_environment_variables(zval *array_ptr)
244244
Z_ARR_P(array_ptr) != Z_ARR(PG(http_globals)[TRACK_VARS_ENV]) &&
245245
zend_hash_num_elements(Z_ARRVAL(PG(http_globals)[TRACK_VARS_ENV])) > 0
246246
) {
247-
zval_dtor(array_ptr);
248-
ZVAL_DUP(array_ptr, &PG(http_globals)[TRACK_VARS_ENV]);
247+
zend_array_destroy(Z_ARR_P(array_ptr));
248+
Z_ARR_P(array_ptr) = zend_array_dup(Z_ARR(PG(http_globals)[TRACK_VARS_ENV]));
249249
return;
250250
} else if (Z_TYPE(PG(http_globals)[TRACK_VARS_SERVER]) == IS_ARRAY &&
251251
Z_ARR_P(array_ptr) != Z_ARR(PG(http_globals)[TRACK_VARS_SERVER]) &&
252252
zend_hash_num_elements(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER])) > 0
253253
) {
254-
zval_dtor(array_ptr);
255-
ZVAL_DUP(array_ptr, &PG(http_globals)[TRACK_VARS_SERVER]);
254+
zend_array_destroy(Z_ARR_P(array_ptr));
255+
Z_ARR_P(array_ptr) = zend_array_dup(Z_ARR(PG(http_globals)[TRACK_VARS_SERVER]));
256256
return;
257257
}
258258

0 commit comments

Comments
 (0)