Skip to content

Commit c56378b

Browse files
committed
Merge branch 'PHP-7.0' into PHP-7.1
* PHP-7.0: fix bug #73471 PHP freezes with AppendIterator
2 parents ed1f64e + 81c2a4b commit c56378b

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed

NEWS

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ PHP NEWS
66
. Fixed bug #74780 (parse_url() borken when query string contains colon).
77
(jhdxr)
88

9+
- SPL:
10+
. Fixed bug #73471 (PHP freezes with AppendIterator). (jhdxr)
11+
912
06 Jul 2017, PHP 7.1.7
1013

1114
- Core:

ext/spl/spl_iterators.c

+6-1
Original file line numberDiff line numberDiff line change
@@ -3374,7 +3374,12 @@ SPL_METHOD(AppendIterator, append)
33743374
if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET, ZEND_NUM_ARGS(), "O", &it, zend_ce_iterator) == FAILURE) {
33753375
return;
33763376
}
3377-
spl_array_iterator_append(&intern->u.append.zarrayit, it);
3377+
if (intern->u.append.iterator->funcs->valid(intern->u.append.iterator) == SUCCESS) {
3378+
spl_array_iterator_append(&intern->u.append.zarrayit, it);
3379+
intern->u.append.iterator->funcs->move_forward(intern->u.append.iterator);
3380+
}else{
3381+
spl_array_iterator_append(&intern->u.append.zarrayit, it);
3382+
}
33783383

33793384
if (!intern->inner.iterator || spl_dual_it_valid(intern) != SUCCESS) {
33803385
if (intern->u.append.iterator->funcs->valid(intern->u.append.iterator) != SUCCESS) {

ext/spl/tests/bug73471.phpt

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
--TEST--
2+
Bug #73471 PHP freezes with AppendIterator
3+
--FILE--
4+
<?php
5+
6+
$iterator = new \AppendIterator();
7+
$events = new \ArrayIterator([1,2,3,4,5]);
8+
$events2 = new \ArrayIterator(['a', 'b', 'c']);
9+
$iterator->append($events);
10+
foreach($events as $event){}
11+
$iterator->append($events2);
12+
?>
13+
===DONE===
14+
--EXPECT--
15+
===DONE===

0 commit comments

Comments
 (0)