fix segfault when node is NULL

tony2001 · tony2001 · commit c4a5af24e0a8 · 2010-12-27T21:47:52.000Z
diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c
@@ -1099,7 +1099,7 @@ static HashTable * sxe_get_prop_hash(zval *object, int is_debug TSRMLS_DC) /* {{
 		if (sxe->iter.type == SXE_ITER_ELEMENT) {
 			node = php_sxe_get_first_node(sxe, node TSRMLS_CC);
 		}
-		if (node->type != XML_ENTITY_DECL) {
+		if (!node || node->type != XML_ENTITY_DECL) {
 			attr = node ? (xmlAttrPtr)node->properties : NULL;
 			zattr = NULL;
 			test = sxe->iter.name && sxe->iter.type == SXE_ITER_ATTRLIST;

Original file line number	Diff line number	Diff line change
`@@ -1099,7 +1099,7 @@ static HashTable * sxe_get_prop_hash(zval object, int is_debug TSRMLS_DC) / {{`
`1099`	`1099`	`if (sxe->iter.type == SXE_ITER_ELEMENT) {`
`1100`	`1100`	`node = php_sxe_get_first_node(sxe, node TSRMLS_CC);`
`1101`	`1101`	`}`
`1102`		`- if (node->type != XML_ENTITY_DECL) {`
	`1102`	`+ if (!node \|\| node->type != XML_ENTITY_DECL) {`
`1103`	`1103`	`attr = node ? (xmlAttrPtr)node->properties : NULL;`
`1104`	`1104`	`zattr = NULL;`
`1105`	`1105`	`test = sxe->iter.name && sxe->iter.type == SXE_ITER_ATTRLIST;`