Skip to content

Commit c25b0a2

Browse files
committed
MFH
- Moved test for bug #44861 to PDO commons and added support for pdo_oci # This allows scrollable cursors to be tested with all the drivers # that currently support them (pgsql and oci), ensuring a consistent # behaviour. The test is skipped when using other drivers.
1 parent db1eafa commit c25b0a2

File tree

1 file changed

+29
-11
lines changed

1 file changed

+29
-11
lines changed

ext/pdo_pgsql/tests/bug44861.phpt renamed to ext/pdo/tests/bug_44861.phpt

+29-11
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,41 @@
11
--TEST--
2-
Bug #44861 (scrollable cursor don't work with pgsql)
2+
PDO Common: Bug #44861 (scrollable cursor don't work with pgsql)
33
--SKIPIF--
4-
<?php
5-
if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded');
6-
require dirname(__FILE__) . '/config.inc';
7-
require dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc';
4+
<?php # vim:ft=php
5+
if (!extension_loaded('pdo')) die('skip');
6+
$dir = getenv('REDIR_TEST_DIR');
7+
if (false == $dir) die('skip no driver');
8+
$allowed = array('oci', 'pgsql');
9+
$ok = false;
10+
foreach ($allowed as $driver) {
11+
if (!strncasecmp(getenv('PDOTEST_DSN'), $driver, strlen($driver))) {
12+
$ok = true;
13+
}
14+
}
15+
if (!$ok) {
16+
die("skip Scrollable cursors not supported");
17+
}
18+
require_once $dir . 'pdo_test.inc';
819
PDOTest::skip();
920
?>
1021
--FILE--
1122
<?php
12-
require dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc';
13-
$dbh = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt');
23+
if (getenv('REDIR_TEST_DIR') === false) putenv('REDIR_TEST_DIR='.dirname(__FILE__) . '/../../pdo/tests/');
24+
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
25+
$db = PDOTest::factory();
1426

15-
$dbh->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
27+
$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
28+
29+
if ($db->getAttribute(PDO::ATTR_DRIVER_NAME) == 'oci') {
30+
$from = 'FROM DUAL';
31+
} else {
32+
$from = '';
33+
}
1634

17-
$query = "SELECT 'row1' AS r UNION SELECT 'row2' UNION SELECT 'row3' UNION SELECT 'row4'";
35+
$query = "SELECT 'row1' AS r $from UNION SELECT 'row2' $from UNION SELECT 'row3' $from UNION SELECT 'row4' $from";
1836
$aParams = array(PDO::ATTR_CURSOR => PDO::CURSOR_SCROLL);
1937

20-
$res = $dbh->prepare($query, $aParams);
38+
$res = $db->prepare($query, $aParams);
2139
$res->execute();
2240
var_dump($res->fetchColumn());
2341
var_dump($res->fetchColumn());
@@ -34,7 +52,7 @@ var_dump($res->fetch(PDO::FETCH_NUM, PDO::FETCH_ORI_REL, -1));
3452
var_dump($res->fetchAll(PDO::FETCH_ASSOC));
3553

3654
// Test binding params via emulated prepared query
37-
$res = $dbh->prepare("SELECT ?", $aParams);
55+
$res = $db->prepare("SELECT ? $from", $aParams);
3856
$res->execute(array("it's working"));
3957
var_dump($res->fetch(PDO::FETCH_NUM));
4058

0 commit comments

Comments
 (0)